[OneDiscover] Add EBT event to track field usage #193996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jughosta
added
release_note:skip
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
davismcphee
approved these changes
Sep 27, 2024
| }); | ||
| }; | ||
|
|
||
| private registerEmbeddable(core: CoreSetup<DiscoverStartPlugins>, plugins: DiscoverSetupPlugins) { | ||
| const ebtManager = new DiscoverEBTManager(); // It is not initialized outside of Discover |
There was a problem hiding this comment.
We may want to consider also tracking the custom events in embeddables too since we don't have the same issue as we do with context. We can discuss first and do it as a followup though if we decide to.
…usage # Conflicts: # src/plugins/discover/public/plugin.tsx
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @jughosta |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11110144397 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 30, 2024
- Closes elastic#186156 - Closes elastic#189454 ## Summary This PR adds new EBT event type `discover_field_usage` which we use for tracking adding and removing grid columns and adding filters via +/-/exists buttons. Properties of the added events consist of: `eventType`: `dataTableSelection`, `dataTableRemoval`, or `filterAddition` `fieldName`: name of the field if it's from ECS schema `filterOperation`: `+`, `-`, or `_exists_` <img width="1002" alt="Screenshot 2024-09-25 at 17 51 27" src="https://github.com/user-attachments/assets/b3f3fb69-55e1-43b2-9683-a6d8884f56fe"> ## Testing Enable "Usage collection" global setting. Navigate to Discover and observe `kibana-browser` requests in Network tab. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 7aa64b6)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 30, 2024
…4457) # Backport This will backport the following commits from `main` to `8.x`: - [[OneDiscover] Add EBT event to track field usage (#193996)](#193996) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-30T16:20:21Z","message":"[OneDiscover] Add EBT event to track field usage (#193996)\n\n- Closes https://github.com/elastic/kibana/issues/186156\r\n- Closes https://github.com/elastic/kibana/issues/189454\r\n\r\n## Summary\r\n\r\nThis PR adds new EBT event type `discover_field_usage` which we use for\r\ntracking adding and removing grid columns and adding filters via\r\n+/-/exists buttons. Properties of the added events consist of:\r\n\r\n`eventType`: `dataTableSelection`, `dataTableRemoval`, or\r\n`filterAddition`\r\n`fieldName`: name of the field if it's from ECS schema\r\n`filterOperation`: `+`, `-`, or `_exists_`\r\n\r\n\r\n<img width=\"1002\" alt=\"Screenshot 2024-09-25 at 17 51 27\"\r\nsrc=\"https://github.com/user-attachments/assets/b3f3fb69-55e1-43b2-9683-a6d8884f56fe\">\r\n\r\n## Testing\r\n\r\nEnable \"Usage collection\" global setting.\r\n\r\nNavigate to Discover and observe `kibana-browser` requests in Network\r\ntab.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"7aa64b6ed59488ab10a5136199b69de0c86668af","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor","Project:OneDiscover"],"title":"[OneDiscover] Add EBT event to track field usage","number":193996,"url":"https://github.com/elastic/kibana/pull/193996","mergeCommit":{"message":"[OneDiscover] Add EBT event to track field usage (#193996)\n\n- Closes https://github.com/elastic/kibana/issues/186156\r\n- Closes https://github.com/elastic/kibana/issues/189454\r\n\r\n## Summary\r\n\r\nThis PR adds new EBT event type `discover_field_usage` which we use for\r\ntracking adding and removing grid columns and adding filters via\r\n+/-/exists buttons. Properties of the added events consist of:\r\n\r\n`eventType`: `dataTableSelection`, `dataTableRemoval`, or\r\n`filterAddition`\r\n`fieldName`: name of the field if it's from ECS schema\r\n`filterOperation`: `+`, `-`, or `_exists_`\r\n\r\n\r\n<img width=\"1002\" alt=\"Screenshot 2024-09-25 at 17 51 27\"\r\nsrc=\"https://github.com/user-attachments/assets/b3f3fb69-55e1-43b2-9683-a6d8884f56fe\">\r\n\r\n## Testing\r\n\r\nEnable \"Usage collection\" global setting.\r\n\r\nNavigate to Discover and observe `kibana-browser` requests in Network\r\ntab.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"7aa64b6ed59488ab10a5136199b69de0c86668af"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193996","number":193996,"mergeCommit":{"message":"[OneDiscover] Add EBT event to track field usage (#193996)\n\n- Closes https://github.com/elastic/kibana/issues/186156\r\n- Closes https://github.com/elastic/kibana/issues/189454\r\n\r\n## Summary\r\n\r\nThis PR adds new EBT event type `discover_field_usage` which we use for\r\ntracking adding and removing grid columns and adding filters via\r\n+/-/exists buttons. Properties of the added events consist of:\r\n\r\n`eventType`: `dataTableSelection`, `dataTableRemoval`, or\r\n`filterAddition`\r\n`fieldName`: name of the field if it's from ECS schema\r\n`filterOperation`: `+`, `-`, or `_exists_`\r\n\r\n\r\n<img width=\"1002\" alt=\"Screenshot 2024-09-25 at 17 51 27\"\r\nsrc=\"https://github.com/user-attachments/assets/b3f3fb69-55e1-43b2-9683-a6d8884f56fe\">\r\n\r\n## Testing\r\n\r\nEnable \"Usage collection\" global setting.\r\n\r\nNavigate to Discover and observe `kibana-browser` requests in Network\r\ntab.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"7aa64b6ed59488ab10a5136199b69de0c86668af"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds new EBT event type
discover_field_usagewhich we use for tracking adding and removing grid columns and adding filters via +/-/exists buttons. Properties of the added events consist of:eventType:dataTableSelection,dataTableRemoval, orfilterAdditionfieldName: name of the field if it's from ECS schemafilterOperation:+,-, or_exists_Testing
Enable "Usage collection" global setting.
Navigate to Discover and observe
kibana-browserrequests in Network tab.Checklist