Update dependency @elastic/charts to v67 (main) #193694

elastic-renovate-prod · 2024-09-23T10:38:58Z

This PR contains the following updates:

Package	Type	Update	Change
@elastic/charts	dependencies	major	`66.1.1` -> `67.0.0`

Breaking changes

Elastic-charts theme API for line and area charts has changed:

the point.visible type for line and area charts is now a union between 'always' | 'never' | 'auto'. Always and Never will replace the previous boolean configuration, auto instead will provide a logic to show the points only of the distance between consecutive points is bigger than the pointVisibilityMinDistance.
the isolatedPoint style for line and area doesn't contain the radius parameter anymore. The radius is derived from the line.strokeWidth parameter.

Release Notes

elastic/elastic-charts (@elastic/charts)

`v67.0.0`

Compare Source

Bug Fixes

deps: update dependency @elastic/eui to ^95.8.0 (#2504) (1ca5dd9)
deps: update dependency @playwright/test to ^1.46.1 (#2511) (b99b3e6)
deps: update dependency json-schema-to-typescript to v15.0.1 (#2510) (a606d72)

Styles

theme: change point and isolated point style and visibility (#2525) (87de6c2)

BREAKING CHANGES

theme: the isolatedPoint style doesn't contain the radius parameter anymore. The radius is derived from the line.strokeWidth parameter.

66.1.1 (2024-08-09)

Bug Fixes

deps: update dependency @elastic/eui to ^95.5.0 (#2496) (803a56a)
deps: update dependency @playwright/test to ^1.45.3 (#2495) (4b82ee2)
deps: update dependency json-schema-to-typescript to v15 (#2497) (d635ebb)
flame: failure when accessing visualViewport.visualViewport from within iFrame (#2502) (84f5328)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

elasticmachine · 2024-09-23T10:39:02Z

Pinging @elastic/kibana-visualizations (Team:Visualizations)

elastic-renovate-prod · 2024-09-26T10:52:45Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

markov00 · 2024-09-30T13:46:41Z

test/functional/page_objects/visual_builder_page.ts

@@ -1007,7 +1007,7 @@ export class VisualBuilderPageObject extends FtrService {

  public async getAreaChartData(chartData?: DebugState, nth: number = 0) {
    const areas = (await this.getChartItems(chartData)) as DebugState['areas'];
-    return areas?.[nth]?.lines.y1.points.map(({ x, y }) => [x, y]);
+    return areas?.[nth]?.lines.y1.points.sort((a, b) => a.x - b.x).map(({ x, y }) => [x, y]);


There isn't a sorting order contract for the DebugState, so the internal state could change everytime without being considered a breaking change. Adding here, and in few other places, a sorting to allow a clean comparison

elasticmachine · 2024-09-30T17:53:30Z

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

elasticmachine · 2024-09-30T17:53:30Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

elasticmachine · 2024-09-30T17:53:30Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

...ability_solution/apm/public/components/shared/charts/helper/get_chart_anomaly_timeseries.tsx

cauemarcondes

LGTM

darnautov

ML changes LGTM

kibana-ci · 2024-10-01T10:36:25Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: f51d7b2
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-193694-f51d7b29e0e7

Failed CI Steps

FTR Configs #30

Test Failures

[job] [logs] FTR Configs #30 / Saved Objects Management saved objects management with hidden types Delete modal should not delete the hidden objects when performing the operation

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.4MB	3.4MB	+16.0B
`dataVisualizer`	726.5KB	726.5KB	+5.0B
`expressionXY`	127.7KB	127.7KB	+19.0B
`ml`	4.6MB	4.6MB	+14.0B
`observabilityAIAssistantApp`	154.3KB	154.3KB	+10.0B
`slo`	854.2KB	854.3KB	+94.0B
`stackAlerts`	75.7KB	75.7KB	+5.0B
`triggersActionsUi`	1.6MB	1.6MB	+10.0B
`visTypeTimelion`	38.8KB	38.8KB	-17.0B
`watcher`	166.0KB	166.0KB	+5.0B
total			+161.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`charts`	45.3KB	45.3KB	+10.0B
`kbnUiSharedDeps-npmDll`	6.2MB	6.2MB	+1.3KB
`observabilityShared`	71.7KB	71.7KB	+10.0B
`triggersActionsUi`	123.3KB	123.3KB	+5.0B
total			+1.3KB

History

💚 Build #238044 succeeded 4bdc8a3
💛 Build #237949 was flaky 3fa524b
💔 Build #237758 failed 36f3d23
💔 Build #237717 failed ba17a2e
💔 Build #237353 failed ea107fa

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @markov00

kibanamachine · 2024-10-02T08:53:18Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11140782250

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@elastic/charts](https://togithub.com/elastic/elastic-charts) | dependencies | major | [`66.1.1` -> `67.0.0`](https://renovatebot.com/diffs/npm/@elastic%2fcharts/66.1.1/67.0.0) | --- ### Breaking changes Elastic-charts theme API for line and area charts has changed: - the `point.visible` type for line and area charts is now a union between `'always' | 'never' | 'auto'`. Always and Never will replace the previous boolean configuration, `auto` instead will provide a logic to show the points only of the distance between consecutive points is bigger than the `pointVisibilityMinDistance`. - the isolatedPoint style for line and area doesn't contain the `radius` parameter anymore. The radius is derived from the `line.strokeWidth` parameter. Co-authored-by: Marco Vettorello <[email protected]> (cherry picked from commit 30ef0ec)

kibanamachine · 2024-10-02T08:57:46Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

) # Backport This will backport the following commits from `main` to `8.x`: - [Update dependency @elastic/charts to v67 (main) (#193694)](#193694)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>

Update dependency @elastic/charts to v67

8d9af7d

elastic-renovate-prod bot added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 23, 2024

kibanamachine added the 💝community label Sep 23, 2024

markov00 self-assigned this Sep 23, 2024

update snapshots and fix breaking changes

939e0c1

markov00 requested review from a team as code owners September 26, 2024 10:44

botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 26, 2024

Merge branch 'main' into renovate/main-@elasticcharts

e968776

markov00 marked this pull request as draft September 26, 2024 10:44

markov00 added 7 commits September 26, 2024 15:03

sort by x the chart debug data

ea107fa

fix debugstate data sorting

06599ba

Merge branch 'main' into renovate/main-@elasticcharts

ba17a2e

fix visible type change

36f3d23

update jest test

35b80ca

Merge branch 'main' into renovate/main-@elasticcharts

3fa524b

Merge branch 'main' into renovate/main-@elasticcharts

4bdc8a3

markov00 reviewed Sep 30, 2024

View reviewed changes

markov00 marked this pull request as ready for review September 30, 2024 13:51

markov00 requested review from a team as code owners September 30, 2024 13:51

nickofthyme approved these changes Sep 30, 2024

View reviewed changes

botelastic bot added Team:Obs AI Assistant Observability AI Assistant Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Sep 30, 2024

cauemarcondes reviewed Sep 30, 2024

View reviewed changes

...ability_solution/apm/public/components/shared/charts/helper/get_chart_anomaly_timeseries.tsx Outdated Show resolved Hide resolved

markov00 added 2 commits October 1, 2024 09:38

fix wrong change

718eb0b

Merge branch 'main' into renovate/main-@elasticcharts

f51d7b2

sabarasaba approved these changes Oct 1, 2024

View reviewed changes

cauemarcondes approved these changes Oct 1, 2024

View reviewed changes

shahzad31 approved these changes Oct 1, 2024

View reviewed changes

darnautov approved these changes Oct 1, 2024

View reviewed changes

angorayc approved these changes Oct 1, 2024

View reviewed changes

dgieselaar approved these changes Oct 2, 2024

View reviewed changes

guskovaue approved these changes Oct 2, 2024

View reviewed changes

markov00 added backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Oct 2, 2024

markov00 merged commit 30ef0ec into main Oct 2, 2024
47 checks passed

markov00 deleted the renovate/main-@elasticcharts branch October 2, 2024 08:52

kibanamachine added the v9.0.0 label Oct 2, 2024

kibanamachine mentioned this pull request Oct 2, 2024

[8.x] Update dependency @elastic/charts to v67 (main) (#193694) #194665

Merged

kibanamachine mentioned this pull request Oct 2, 2024

[fix] type issue from race condition on merge #194676

Merged

kibanamachine added the v8.16.0 label Oct 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependency @elastic/charts to v67 (main) #193694

Update dependency @elastic/charts to v67 (main) #193694

elastic-renovate-prod bot commented Sep 23, 2024 •

edited by kibanamachine

Loading

elasticmachine commented Sep 23, 2024

elastic-renovate-prod bot commented Sep 26, 2024

markov00 Sep 30, 2024

elasticmachine commented Sep 30, 2024

elasticmachine commented Sep 30, 2024

elasticmachine commented Sep 30, 2024

cauemarcondes left a comment

darnautov left a comment

kibana-ci commented Oct 1, 2024 •

edited

Loading

kibanamachine commented Oct 2, 2024

kibanamachine commented Oct 2, 2024

Update dependency @elastic/charts to v67 (main) #193694

Update dependency @elastic/charts to v67 (main) #193694

Conversation

elastic-renovate-prod bot commented Sep 23, 2024 • edited by kibanamachine Loading

Breaking changes

Release Notes

v67.0.0

Bug Fixes

Styles

BREAKING CHANGES

66.1.1 (2024-08-09)

Bug Fixes

Configuration

elasticmachine commented Sep 23, 2024

elastic-renovate-prod bot commented Sep 26, 2024

Edited/Blocked Notification

markov00 Sep 30, 2024

Choose a reason for hiding this comment

elasticmachine commented Sep 30, 2024

elasticmachine commented Sep 30, 2024

elasticmachine commented Sep 30, 2024

cauemarcondes left a comment

Choose a reason for hiding this comment

darnautov left a comment

Choose a reason for hiding this comment

kibana-ci commented Oct 1, 2024 • edited Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Page load bundle

History

kibanamachine commented Oct 2, 2024

kibanamachine commented Oct 2, 2024

💚 All backports created successfully

Questions ?

elastic-renovate-prod bot commented Sep 23, 2024 •

edited by kibanamachine

Loading

`v67.0.0`

kibana-ci commented Oct 1, 2024 •

edited

Loading