Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Infra] Amend inventory title to "Infrastructure Inventory" (#193189) #193523

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…193189)

## Summary

Update the Inventory title terminology to be "Infrastructure Inventory",
in order to differentiate from the incoming top-level "Inventory" page.

<img width="481" alt="Screenshot 2024-09-17 170745"
src="https://github.com/user-attachments/assets/d72dfb6e-fe3b-44d8-b6f0-ae333586ceb4">

Closes elastic#192324

# How to test

- Load Elastic cluster, go to Infrastructure -> Infrastructure Inventory

**Expected**: The side menu link text should match the breadcrumb title
and the main title text for the page.

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 04c3486)
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.6MB 1.6MB -1.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 51.1KB 52.4KB +1.3KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Bluefinger

@kibanamachine kibanamachine merged commit 1827d2e into elastic:8.x Sep 20, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants