Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Fleet] use @kbn/config-schema in Fleet API (Part 1) (#192883) #193296

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary

Relates elastic#184685

Readd elastic#192447 with fixes and tests
to validate that the response schemas are correct.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 406f073)
@kibanamachine kibanamachine enabled auto-merge (squash) September 18, 2024 13:18
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Sep 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

@kibanamachine kibanamachine merged commit 9672d81 into elastic:8.x Sep 18, 2024
26 checks passed
juliaElastic added a commit to juliaElastic/kibana that referenced this pull request Sep 19, 2024
juliaElastic added a commit that referenced this pull request Sep 20, 2024
…193424)

Revert #193296

We decided to target 9.x only with these changes, as it makes the
response schema validation stricter and might include some changes that
can be considered breaking.

Relates #184685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants