Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability] fix slo observability compressed styles to be not compressed #193081
[Observability] fix slo observability compressed styles to be not compressed #193081
Changes from 27 commits
2fb8a5a
67ea6a2
cf01d44
c9d3ffe
0b6fbc0
8c45a2a
5354eb0
e590230
caa0bf2
7f0d2f3
2831847
a722e87
913f0ff
bb6a928
451d33c
c9a2d59
4cf021a
cf410d8
9c60c87
83da3f5
02f6a67
9e32829
c986f23
ad6ee2c
899b248
adc1846
bb77b0d
b21f593
00c0670
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the range slider + time slider controls also use the
compressed
prop on their components, no? We should make this consistent, even if the SLO page does not use these control typesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good - I'm down for consistency bb77b0d for changes