-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SLOs] Fix slo control compressed style !! #192993
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
rshen91
added a commit
that referenced
this pull request
Oct 1, 2024
…pressed (#193081) ## Summary Building off of PR #192993 to revert the compressed styles for SLOs Compressed styles PR [here](#190636) ### Before In the SLO page in Observability, the status and tags fields are uneven with the unified search bar. ![Screenshot 2024-09-30 at 2 10 17 PM](https://github.com/user-attachments/assets/63391aa2-ec7d-43f5-9803-8094e73b8a6c) ### After ![Screenshot 2024-09-30 at 2 52 37 PM](https://github.com/user-attachments/assets/fb70109d-15d1-4278-81c6-318da290594f)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2024
…pressed (elastic#193081) ## Summary Building off of PR elastic#192993 to revert the compressed styles for SLOs Compressed styles PR [here](elastic#190636) ### Before In the SLO page in Observability, the status and tags fields are uneven with the unified search bar. ![Screenshot 2024-09-30 at 2 10 17 PM](https://github.com/user-attachments/assets/63391aa2-ec7d-43f5-9803-8094e73b8a6c) ### After ![Screenshot 2024-09-30 at 2 52 37 PM](https://github.com/user-attachments/assets/fb70109d-15d1-4278-81c6-318da290594f) (cherry picked from commit 7a9a519)
kibanamachine
added a commit
that referenced
this pull request
Oct 2, 2024
…ot compressed (#193081) (#194650) # Backport This will backport the following commits from `main` to `8.x`: - [[Observability] fix slo observability compressed styles to be not compressed (#193081)](#193081) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rachel Shen","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-01T23:01:20Z","message":"[Observability] fix slo observability compressed styles to be not compressed (#193081)\n\n## Summary\r\n\r\nBuilding off of PR #192993 to\r\nrevert the compressed styles for SLOs\r\n\r\nCompressed styles PR\r\n[here](https://github.com/elastic/kibana/pull/190636)\r\n\r\n\r\n### Before\r\nIn the SLO page in Observability, the status and tags fields are uneven\r\nwith the unified search bar.\r\n![Screenshot 2024-09-30 at 2 10\r\n17 PM](https://github.com/user-attachments/assets/63391aa2-ec7d-43f5-9803-8094e73b8a6c)\r\n\r\n### After\r\n![Screenshot 2024-09-30 at 2 52\r\n37 PM](https://github.com/user-attachments/assets/fb70109d-15d1-4278-81c6-318da290594f)","sha":"7a9a5194d7acf8a9e507ae6b6acc9d22f56cf2ea","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Observability] fix slo observability compressed styles to be not compressed","number":193081,"url":"https://github.com/elastic/kibana/pull/193081","mergeCommit":{"message":"[Observability] fix slo observability compressed styles to be not compressed (#193081)\n\n## Summary\r\n\r\nBuilding off of PR #192993 to\r\nrevert the compressed styles for SLOs\r\n\r\nCompressed styles PR\r\n[here](https://github.com/elastic/kibana/pull/190636)\r\n\r\n\r\n### Before\r\nIn the SLO page in Observability, the status and tags fields are uneven\r\nwith the unified search bar.\r\n![Screenshot 2024-09-30 at 2 10\r\n17 PM](https://github.com/user-attachments/assets/63391aa2-ec7d-43f5-9803-8094e73b8a6c)\r\n\r\n### After\r\n![Screenshot 2024-09-30 at 2 52\r\n37 PM](https://github.com/user-attachments/assets/fb70109d-15d1-4278-81c6-318da290594f)","sha":"7a9a5194d7acf8a9e507ae6b6acc9d22f56cf2ea"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193081","number":193081,"mergeCommit":{"message":"[Observability] fix slo observability compressed styles to be not compressed (#193081)\n\n## Summary\r\n\r\nBuilding off of PR #192993 to\r\nrevert the compressed styles for SLOs\r\n\r\nCompressed styles PR\r\n[here](https://github.com/elastic/kibana/pull/190636)\r\n\r\n\r\n### Before\r\nIn the SLO page in Observability, the status and tags fields are uneven\r\nwith the unified search bar.\r\n![Screenshot 2024-09-30 at 2 10\r\n17 PM](https://github.com/user-attachments/assets/63391aa2-ec7d-43f5-9803-8094e73b8a6c)\r\n\r\n### After\r\n![Screenshot 2024-09-30 at 2 52\r\n37 PM](https://github.com/user-attachments/assets/fb70109d-15d1-4278-81c6-318da290594f)","sha":"7a9a5194d7acf8a9e507ae6b6acc9d22f56cf2ea"}}]}] BACKPORT--> Co-authored-by: Rachel Shen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
before