-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HTTP] Set explicit access for public
HTTP APIs 2
#192579
[HTTP] Set explicit access for public
HTTP APIs 2
#192579
Conversation
Pinging @elastic/kibana-core (Team:Core) |
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Management changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM based on #192554 changes.
Not sure about CI failures.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @jloleysens |
## Summary Part 2 of this [PR](elastic#192554). See more info there. <img width="229" alt="Screenshot 2024-09-11 at 14 50 11" src="https://github.com/user-attachments/assets/585f1ce8-2987-4355-a4b1-e13705646b48"> --------- Co-authored-by: shahzad31 <[email protected]> (cherry picked from commit 244ff7b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…192579) (#193938) # Backport This will backport the following commits from `main` to `8.x`: - [[HTTP] Set explicit access for `public` HTTP APIs 2 (#192579)](#192579) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jean-Louis Leysens","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-25T07:25:12Z","message":"[HTTP] Set explicit access for `public` HTTP APIs 2 (#192579)\n\n## Summary\r\n\r\nPart 2 of this [PR](#192554). See\r\nmore info there.\r\n\r\n<img width=\"229\" alt=\"Screenshot 2024-09-11 at 14 50 11\"\r\nsrc=\"https://github.com/user-attachments/assets/585f1ce8-2987-4355-a4b1-e13705646b48\">\r\n\r\n---------\r\n\r\nCo-authored-by: shahzad31 <[email protected]>","sha":"244ff7b2c37f66518dbb0d7121a8d02b1405fe93","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:http","Team:Core","release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0","backport:version"],"title":"[HTTP] Set explicit access for `public` HTTP APIs 2","number":192579,"url":"https://github.com/elastic/kibana/pull/192579","mergeCommit":{"message":"[HTTP] Set explicit access for `public` HTTP APIs 2 (#192579)\n\n## Summary\r\n\r\nPart 2 of this [PR](#192554). See\r\nmore info there.\r\n\r\n<img width=\"229\" alt=\"Screenshot 2024-09-11 at 14 50 11\"\r\nsrc=\"https://github.com/user-attachments/assets/585f1ce8-2987-4355-a4b1-e13705646b48\">\r\n\r\n---------\r\n\r\nCo-authored-by: shahzad31 <[email protected]>","sha":"244ff7b2c37f66518dbb0d7121a8d02b1405fe93"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192579","number":192579,"mergeCommit":{"message":"[HTTP] Set explicit access for `public` HTTP APIs 2 (#192579)\n\n## Summary\r\n\r\nPart 2 of this [PR](#192554). See\r\nmore info there.\r\n\r\n<img width=\"229\" alt=\"Screenshot 2024-09-11 at 14 50 11\"\r\nsrc=\"https://github.com/user-attachments/assets/585f1ce8-2987-4355-a4b1-e13705646b48\">\r\n\r\n---------\r\n\r\nCo-authored-by: shahzad31 <[email protected]>","sha":"244ff7b2c37f66518dbb0d7121a8d02b1405fe93"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jean-Louis Leysens <[email protected]>
Summary
Part 2 of this PR. See more info there.