Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTTP] Set explicit access for public HTTP APIs 2 #192579

Merged
merged 8 commits into from
Sep 25, 2024

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Sep 11, 2024

Summary

Part 2 of this PR. See more info there.

Screenshot 2024-09-11 at 14 50 11

@jloleysens jloleysens added Feature:http Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes v8.16.0 labels Sep 11, 2024
@jloleysens jloleysens self-assigned this Sep 11, 2024
@jloleysens jloleysens requested review from a team as code owners September 11, 2024 13:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Sep 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Management changes LGTM

Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jloleysens jloleysens added backport:version Backport to applied version labels v9.0.0 labels Sep 23, 2024
Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on #192554 changes.
Not sure about CI failures.

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 24, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 3c04f13
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-192579-3c04f13e92ba

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #24 / serverless observability UI Dataset Quality Flyout navigate to dataset details should navigate to details page from a main page

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jloleysens

@jloleysens jloleysens merged commit 244ff7b into elastic:main Sep 25, 2024
28 checks passed
@jloleysens jloleysens deleted the http/explicit-access-part-ii branch September 25, 2024 07:25
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 25, 2024
## Summary

Part 2 of this [PR](elastic#192554). See
more info there.

<img width="229" alt="Screenshot 2024-09-11 at 14 50 11"
src="https://github.com/user-attachments/assets/585f1ce8-2987-4355-a4b1-e13705646b48">

---------

Co-authored-by: shahzad31 <[email protected]>
(cherry picked from commit 244ff7b)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 25, 2024
…192579) (#193938)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[HTTP] Set explicit access for &#x60;public&#x60; HTTP APIs 2
(#192579)](#192579)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jean-Louis
Leysens","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-25T07:25:12Z","message":"[HTTP]
Set explicit access for `public` HTTP APIs 2 (#192579)\n\n##
Summary\r\n\r\nPart 2 of this
[PR](#192554). See\r\nmore info
there.\r\n\r\n<img width=\"229\" alt=\"Screenshot 2024-09-11 at 14 50
11\"\r\nsrc=\"https://github.com/user-attachments/assets/585f1ce8-2987-4355-a4b1-e13705646b48\">\r\n\r\n---------\r\n\r\nCo-authored-by:
shahzad31
<[email protected]>","sha":"244ff7b2c37f66518dbb0d7121a8d02b1405fe93","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:http","Team:Core","release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0","backport:version"],"title":"[HTTP]
Set explicit access for `public` HTTP APIs
2","number":192579,"url":"https://github.com/elastic/kibana/pull/192579","mergeCommit":{"message":"[HTTP]
Set explicit access for `public` HTTP APIs 2 (#192579)\n\n##
Summary\r\n\r\nPart 2 of this
[PR](#192554). See\r\nmore info
there.\r\n\r\n<img width=\"229\" alt=\"Screenshot 2024-09-11 at 14 50
11\"\r\nsrc=\"https://github.com/user-attachments/assets/585f1ce8-2987-4355-a4b1-e13705646b48\">\r\n\r\n---------\r\n\r\nCo-authored-by:
shahzad31
<[email protected]>","sha":"244ff7b2c37f66518dbb0d7121a8d02b1405fe93"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192579","number":192579,"mergeCommit":{"message":"[HTTP]
Set explicit access for `public` HTTP APIs 2 (#192579)\n\n##
Summary\r\n\r\nPart 2 of this
[PR](#192554). See\r\nmore info
there.\r\n\r\n<img width=\"229\" alt=\"Screenshot 2024-09-11 at 14 50
11\"\r\nsrc=\"https://github.com/user-attachments/assets/585f1ce8-2987-4355-a4b1-e13705646b48\">\r\n\r\n---------\r\n\r\nCo-authored-by:
shahzad31
<[email protected]>","sha":"244ff7b2c37f66518dbb0d7121a8d02b1405fe93"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jean-Louis Leysens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project Feature:http release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:obs-ux-management Observability Management User Experience Team v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants