Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs explorer] Using dockerized package registry in tests #192064

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Sep 4, 2024

Closes #190343.

This PR aims to use a dockerized package registry version for testing.
In order to test it locally you have to set the value of FLEET_PACKAGE_REGISTRY_PORT env var in your terminal, and you also need to have a docker daemon running.

For example, you can open a terminal and start the server

  yarn test:ftr:server --config ./x-pack/test/functional/apps/observability_logs_explorer/config.ts

then open a new terminal set the var value and start the runner with the specific test using this configuration

  export set FLEET_PACKAGE_REGISTRY_PORT=12345
  yarn test:ftr:runner --config ./x-pack/test/functional/apps/observability_logs_explorer/config.ts --include ./x-pack/test/functional/apps/observability_logs_explorer/data_source_selector

If you want to test again without the dockerized version, you should remove the value of the var

  unset FLEET_PACKAGE_REGISTRY_PORT 

@yngrdyn yngrdyn requested a review from a team as a code owner September 4, 2024 09:20
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn force-pushed the 190343-failing-test-serverless-observability-functional-testsx-packtest_serverlessfunctionaltest_suitesobservabilityobservability_logs_explorerdata_source_selectorts branch from 26137de to 3ebc2a1 Compare September 4, 2024 09:23
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 4, 2024
@yngrdyn yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label Sep 4, 2024
@yngrdyn yngrdyn requested a review from a team as a code owner September 4, 2024 10:00
…-functional-testsx-packtest_serverlessfunctionaltest_suitesobservabilityobservability_logs_explorerdata_source_selectorts
@yngrdyn yngrdyn self-assigned this Sep 4, 2024
…-testsx-packtest_serverlessfunctionaltest_suitesobservabilityobservability_logs_explorerdata_source_selectorts' of github.com:yngrdyn/kibana into 190343-failing-test-serverless-observability-functional-testsx-packtest_serverlessfunctionaltest_suitesobservabilityobservability_logs_explorerdata_source_selectorts
…-functional-testsx-packtest_serverlessfunctionaltest_suitesobservabilityobservability_logs_explorerdata_source_selectorts
@yngrdyn yngrdyn requested a review from pheyos September 6, 2024 06:19
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…-testsx-packtest_serverlessfunctionaltest_suitesobservabilityobservability_logs_explorerdata_source_selectorts' of github.com:yngrdyn/kibana into 190343-failing-test-serverless-observability-functional-testsx-packtest_serverlessfunctionaltest_suitesobservabilityobservability_logs_explorerdata_source_selectorts
…-functional-testsx-packtest_serverlessfunctionaltest_suitesobservabilityobservability_logs_explorerdata_source_selectorts
@yngrdyn yngrdyn requested a review from tonyghiani September 6, 2024 08:52
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yngrdyn yngrdyn enabled auto-merge (squash) September 6, 2024 09:12
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 6, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 5df3bdf
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-192064-5df3bdf24d40

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yngrdyn

@yngrdyn yngrdyn merged commit d8445cc into elastic:main Sep 6, 2024
27 checks passed
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Sep 6, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment