-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs explorer] Using dockerized package registry in tests #192064
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
26137de
to
3ebc2a1
Compare
…-functional-testsx-packtest_serverlessfunctionaltest_suitesobservabilityobservability_logs_explorerdata_source_selectorts
… in api and functional tests
…-testsx-packtest_serverlessfunctionaltest_suitesobservabilityobservability_logs_explorerdata_source_selectorts' of github.com:yngrdyn/kibana into 190343-failing-test-serverless-observability-functional-testsx-packtest_serverlessfunctionaltest_suitesobservabilityobservability_logs_explorerdata_source_selectorts
…-functional-testsx-packtest_serverlessfunctionaltest_suitesobservabilityobservability_logs_explorerdata_source_selectorts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
x-pack/test/functional/apps/observability_logs_explorer/config.ts
Outdated
Show resolved
Hide resolved
…-testsx-packtest_serverlessfunctionaltest_suitesobservabilityobservability_logs_explorerdata_source_selectorts' of github.com:yngrdyn/kibana into 190343-failing-test-serverless-observability-functional-testsx-packtest_serverlessfunctionaltest_suitesobservabilityobservability_logs_explorerdata_source_selectorts
…-functional-testsx-packtest_serverlessfunctionaltest_suitesobservabilityobservability_logs_explorerdata_source_selectorts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @yngrdyn |
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
Closes #190343.
This PR aims to use a dockerized package registry version for testing.
In order to test it locally you have to set the value of
FLEET_PACKAGE_REGISTRY_PORT
env var in your terminal, and you also need to have a docker daemon running.For example, you can open a terminal and start the server
then open a new terminal set the var value and start the runner with the specific test using this configuration
If you want to test again without the dockerized version, you should remove the value of the var