[ObsUX][Infra] Fix loading spinner and tooltip for host from APM #191908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiriamAparicio
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
miloszmarcinkowski
approved these changes
Sep 2, 2024
jennypavlova
requested changes
Sep 2, 2024
...ervability_solution/infra/public/components/asset_details/header/page_title_with_popover.tsx
Show resolved
Hide resolved
x-pack/plugins/observability_solution/infra/public/components/asset_details/template/flyout.tsx
Outdated
Show resolved
Hide resolved
MiriamAparicio
force-pushed
the
191579-fix-loading-spiner-asset-name
branch
from
9665c20 to
d5b93ce
Compare
MiriamAparicio
force-pushed
the
191579-fix-loading-spiner-asset-name
branch
from
38d96dd to
a2a7c29
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
jennypavlova
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #191579
Summary
When working on finding the root cause of the bug, another bug related was discovered on the host detected by APM tooltip, it was introduced by this PR when we check for
metadataLoadingto finish, as we don’t do it for the asset details page the loading spinner wasn’t shown there when refreshing the page, but the tooltip shows because is still waiting for the metadata request to finish in order to retrieve the integration.To fix this, we don't apply loading spinner to the asset name, but we do it for the tooltip
BEFORE
Screen.Recording.2024-08-30.at.15.43.48.mov
AFTER
Screen.Recording.2024-09-02.at.12.40.42.mov