Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui-shared-deps): add @kbn/ebt-tools #191754

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

afharo
Copy link
Member

@afharo afharo commented Aug 29, 2024

Summary

When looking at #187424, I noticed that the only place where we actually import @elastic/apm-rum-core is in @kbn/ebt-tool. So, checking if adding this library to the shared deps improved anything.

For maintainers

@afharo
Copy link
Member Author

afharo commented Aug 29, 2024

/ci

@afharo
Copy link
Member Author

afharo commented Aug 29, 2024

/ci

@afharo
Copy link
Member Author

afharo commented Aug 29, 2024

/ci

@afharo afharo marked this pull request as ready for review August 30, 2024 00:17
@afharo afharo requested review from a team as code owners August 30, 2024 00:17
@afharo afharo added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team labels Aug 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #97 / serverless observability UI Serverless Observability Cases Cases list row actions Severity to high

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 590 581 -9
apm 1875 1866 -9
cloudSecurityPosture 645 636 -9
core 452 443 -9
dashboard 573 564 -9
dataQuality 98 89 -9
datasetQuality 231 222 -9
dataVisualizer 747 738 -9
discover 966 957 -9
esqlDataGrid 354 345 -9
eventAnnotationListing 578 569 -9
exploratoryView 191 182 -9
infra 1514 1505 -9
lens 1446 1437 -9
logsExplorer 555 546 -9
observability 1054 1045 -9
savedObjectsTagging 116 107 -9
securitySolution 5661 5652 -9
slo 835 826 -9
synthetics 1031 1022 -9
transform 448 439 -9
unifiedDocViewer 219 210 -9
total -198

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ui-shared-deps-src 49 50 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 548.7KB 547.2KB -1.6KB
apm 3.5MB 3.5MB -1.8KB
core 66.2KB 65.3KB -924.0B
dashboard 463.3KB 461.3KB -2.0KB
dataQuality 29.8KB 28.0KB -1.7KB
datasetQuality 205.3KB 204.1KB -1.1KB
dataVisualizer 726.4KB 724.9KB -1.6KB
discover 771.2KB 769.8KB -1.3KB
eventAnnotationListing 228.4KB 227.1KB -1.3KB
exploratoryView 184.3KB 182.7KB -1.6KB
infra 1.5MB 1.5MB -1.1KB
lens 1.5MB 1.5MB -1.6KB
savedObjectsTagging 48.1KB 46.9KB -1.2KB
securitySolution 17.9MB 17.9MB -1.6KB
slo 831.7KB 829.0KB -2.7KB
synthetics 940.7KB 938.8KB -1.9KB
transform 550.1KB 548.6KB -1.6KB
unifiedDocViewer 120.7KB 119.7KB -951.0B
total -27.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
aiops 7.9KB 7.9KB -6.0B
apm 39.9KB 39.9KB -6.0B
core 420.6KB 418.5KB -2.1KB
dashboard 43.4KB 43.4KB -6.0B
dataQuality 7.9KB 7.9KB -6.0B
datasetQuality 49.3KB 48.6KB -747.0B
dataVisualizer 24.5KB 24.5KB -6.0B
discover 48.0KB 47.9KB -6.0B
eventAnnotationListing 11.1KB 11.1KB -6.0B
exploratoryView 44.0KB 44.0KB -6.0B
infra 97.7KB 97.0KB -805.0B
kbnUiSharedDeps-srcJs 3.3MB 3.3MB +3.1KB
lens 51.7KB 51.7KB -6.0B
savedObjectsTagging 22.9KB 22.6KB -314.0B
securitySolution 86.3KB 86.4KB +55.0B
slo 24.7KB 24.7KB -6.0B
synthetics 37.0KB 37.0KB -6.0B
transform 18.7KB 18.7KB -6.0B
unifiedDocViewer 12.2KB 11.7KB -509.0B
total -1.3KB
Unknown metric groups

API count

id before after diff
@kbn/ui-shared-deps-src 58 59 +1

async chunk count

id before after diff
aiops 31 30 -1
apm 37 36 -1
core 3 2 -1
dashboard 14 13 -1
dataQuality 2 1 -1
datasetQuality 16 15 -1
dataVisualizer 20 19 -1
discover 28 27 -1
eventAnnotationListing 6 5 -1
exploratoryView 8 7 -1
infra 18 17 -1
lens 25 24 -1
savedObjectsTagging 5 4 -1
securitySolution 98 97 -1
slo 31 30 -1
synthetics 16 15 -1
transform 4 3 -1
unifiedDocViewer 11 10 -1
total -18

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit 63ca436 into elastic:main Aug 30, 2024
26 checks passed
@afharo afharo deleted the add-ebt-tools-to-shared-deps branch August 30, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants