Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra][Flaky Test Fix] Failing test: Single Host Flyout Tabs Metadata Tab should render metadata tab, add and remove filter #191745

Merged
merged 1 commit into from
Aug 30, 2024
Merged

[Infra][Flaky Test Fix] Failing test: Single Host Flyout Tabs Metadata Tab should render metadata tab, add and remove filter #191745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...lution/infra/public/components/asset_details/tabs/metadata/add_metadata_filter_button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export const AddMetadataFilterButton = ({ item }: AddMetadataFilterButtonProps)
}

return (
<span>
<span data-test-subj={`infraAssetDetailsMetadataField.${item.name}`}>
<EuiToolTip
content={i18n.translate('xpack.infra.metadataEmbeddable.setFilterByValueTooltip', {
defaultMessage: 'Filter by value',
Expand Down
4 changes: 3 additions & 1 deletion x-pack/test/functional/page_objects/asset_details.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,9 @@ export function AssetDetailsProvider({ getService }: FtrProviderContext) {
},

async clickAddMetadataFilter() {
return testSubjects.click('infraAssetDetailsMetadataAddFilterButton');
// Make this selector tied to the field to avoid flakiness
// https://github.com/elastic/kibana/issues/191565
return testSubjects.click('infraAssetDetailsMetadataField.host.name');
},

async clickRemoveMetadataFilter() {
Expand Down
Loading