[Infra] Remove beta badge from hosts #191664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennypavlova
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jennypavlova
changed the title
crespocarlos
approved these changes
Aug 29, 2024
| @@ -46,7 +46,7 @@ const TitleWithPopoverMessage = ({ | |||
| embeddableId: string; | |||
| }) => { | |||
| return ( | |||
| <EuiFormLabel className="controlFrame__formControlLayoutLabel" htmlFor={embeddableId}> | |||
| <EuiFormLabel htmlFor={embeddableId}> | |||
| <EuiFlexGroup alignItems="center" gutterSize="xs"> | |||
There was a problem hiding this comment.
On small screens, the tooltip is jumping to a new line. Could we add resposive={false} here as part of this PR?
There was a problem hiding this comment.
Thanks for spotting that! I applied the suggestion and it is fixed now 🙌
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
bmorelli25
approved these changes
Aug 29, 2024
mykolaharmash
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #191163
Summary
This PR removes the
betalabel from hosts viewin Inventory
in the menu and page title
in the settings
Small bugfix
I saw that a class added to the service control label was causing a wrong negative left margin and it bugged me so I fixed it here 😅: