[Infra][Hosts] Display N/A badge for APM hosts without system metrics #191181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblancof
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
...bservability_solution/infra/public/pages/metrics/hosts/components/table/add_data_popover.tsx
Outdated
Show resolved
Hide resolved
...bservability_solution/infra/public/pages/metrics/hosts/components/table/add_data_popover.tsx
Outdated
Show resolved
Hide resolved
...lugins/observability_solution/infra/public/pages/metrics/hosts/hooks/use_hosts_table.test.ts
Outdated
Show resolved
Hide resolved
...bservability_solution/infra/public/pages/metrics/hosts/components/table/add_data_popover.tsx
Outdated
Show resolved
Hide resolved
...bservability_solution/infra/public/pages/metrics/hosts/components/table/add_data_popover.tsx
Outdated
Show resolved
Hide resolved
|
I tested the popover and it works as expected and has the correct links, thanks for adding it 💯 |
...bservability_solution/infra/public/pages/metrics/hosts/components/table/add_data_popover.tsx
Outdated
Show resolved
Hide resolved
...ck/plugins/observability_solution/infra/public/pages/metrics/hosts/hooks/use_hosts_table.tsx
Outdated
Show resolved
Hide resolved
...ck/plugins/observability_solution/infra/public/pages/metrics/hosts/hooks/use_hosts_table.tsx
Show resolved
Hide resolved
…w !hasSystemMetrics
…within the same file
…inter suggestions
iblancof
force-pushed
the
190516-infra-display-na-badge-for-apm-hosts-with-metrics-with-null-value
branch
from
808bd3d to
e44500c
Compare
…with-metrics-with-null-value
…with-metrics-with-null-value
…with-metrics-with-null-value
crespocarlos
approved these changes
Aug 27, 2024
…with-metrics-with-null-value
…with-metrics-with-null-value
jennypavlova
approved these changes
Aug 27, 2024
...ck/plugins/observability_solution/infra/public/pages/metrics/hosts/hooks/use_hosts_table.tsx
Outdated
Show resolved
Hide resolved
...ck/plugins/observability_solution/infra/public/pages/metrics/hosts/hooks/use_hosts_table.tsx
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @iblancof |
iblancof
deleted the
190516-infra-display-na-badge-for-apm-hosts-with-metrics-with-null-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #190516
This PR introduces an "N/A" badge for hosts that are returned by the
metrics/infra/hostAPI withhasSystemMetricsset tofalse. This enhancement will help users quickly identify and address issues with APM hosts that are not monitored by the system integration. The badge will provide an explanation of the problem and suggest troubleshooting steps.Automated tests
Upon reviewing the code, I noticed that this screen is covered by functional tests.
My initial idea was to add some functional tests to verify the badge display as well as the button and link redirections. However, I found that this is quite complex, as it involves modifying the data used in the tests, and I’m still not very familiar with that process.
Given the deadline for this epic, I’ve decided not to include tests in this issue. If we believe they are really necessary, I would need to spend some time understanding how data is managed in our functional testing layer. Any feedback on this would be greatly appreciated.