Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDR Workflows] Improve event filters related cy tests #190610

Merged

Conversation

gergoabraham
Copy link
Contributor

@gergoabraham gergoabraham commented Aug 15, 2024

Summary

reducing potential flakyness in cypress tests handling event filters, by applying same change as #189961: enter text instead of selecting from dropdown

Note

revert da247c5 before merge - done ✅

flaky runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6782

@gergoabraham gergoabraham added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Defend Workflows “EDR Workflows” sub-team of Security Solution OLM Sprint labels Aug 15, 2024
@gergoabraham gergoabraham self-assigned this Aug 15, 2024
@gergoabraham
Copy link
Contributor Author

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6782

[✅] Security Solution Defend Workflows - Cypress: 25/25 tests passed.
[✅] [Serverless] Security Solution Defend Workflows - Cypress: 25/25 tests passed.

see run history

@gergoabraham gergoabraham marked this pull request as ready for review August 19, 2024 12:16
@gergoabraham gergoabraham requested a review from a team as a code owner August 19, 2024 12:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@gergoabraham gergoabraham enabled auto-merge (squash) August 19, 2024 13:55
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #29 / Rules Management - Rule Read API @ess resolve_read_rules reading rules "before each" hook for "should create a "migrated" rule where querying for the new SO _id will resolve the new object and not return the outcome field when outcome === exactMatch"
  • [job] [logs] FTR Configs #2 / telemetry /api/telemetry/v2/config API Telemetry config GET should get updated labels after dynamically updating them

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @gergoabraham

@gergoabraham gergoabraham merged commit e7aabcd into elastic:main Aug 19, 2024
41 checks passed
@gergoabraham gergoabraham deleted the improve-event-filters-related-cy-tests branch August 19, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting OLM Sprint release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants