Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix translation #190504

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Fix translation #190504

merged 1 commit into from
Aug 14, 2024

Conversation

maryam-saeidi
Copy link
Member

Not sure why CI didn't fail in the main PR, but it did in the backport 🤔

@maryam-saeidi maryam-saeidi added the release_note:skip Skip the PR/issue when compiling release notes label Aug 14, 2024
@maryam-saeidi maryam-saeidi self-assigned this Aug 14, 2024
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner August 14, 2024 11:45
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Aug 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

dominiqueclarke
dominiqueclarke approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maryam-saeidi maryam-saeidi enabled auto-merge (squash) August 14, 2024 11:50
@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 14, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: faf926f
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-190504-faf926f98d04

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

@maryam-saeidi maryam-saeidi merged commit 5ce3611 into elastic:main Aug 14, 2024
32 checks passed
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 14, 2024
@maryam-saeidi maryam-saeidi deleted the fix-i18n branch August 14, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees

@maryam-saeidi maryam-saeidi

Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maryam-saeidi @elasticmachine @obltmachine @kibana-ci @dominiqueclarke @kibanamachine