Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLOs] Update get SLOs flaky test #190443

Merged
merged 12 commits into from
Oct 21, 2024
Merged

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Aug 13, 2024

Summary

fixes #177806

Update get SLOs flaky test !!

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 marked this pull request as ready for review August 14, 2024 07:53
@shahzad31 shahzad31 requested a review from a team as a code owner August 14, 2024 07:53
@shahzad31 shahzad31 added the release_note:skip Skip the PR/issue when compiling release notes label Aug 14, 2024
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transform changes LGTM

@shahzad31 shahzad31 added backport:skip This commit does not require backporting backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Oct 7, 2024
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 7, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #43 / SLO API Tests GetSLOs gets slos instances
  • [job] [logs] FTR Configs #43 / SLO API Tests GetSLOs gets slos instances

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@shahzad31 shahzad31 merged commit ff44bf2 into elastic:main Oct 21, 2024
26 checks passed
@shahzad31 shahzad31 deleted the slo-flaky-test branch October 21, 2024 15:31
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11443541505

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 21, 2024
## Summary

fixes elastic#177806

Update get SLOs flaky test !!

(cherry picked from commit ff44bf2)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 21, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[SLOs] Update get SLOs flaky test
(#190443)](#190443)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-21T15:31:29Z","message":"[SLOs]
Update get SLOs flaky test (#190443)\n\n## Summary\r\n\r\nfixes
https://github.com/elastic/kibana/issues/177806\r\n\r\nUpdate get SLOs
flaky test
!!","sha":"ff44bf2770bbf00479ea3a6169c892a9a2cee534","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[SLOs]
Update get SLOs flaky
test","number":190443,"url":"https://github.com/elastic/kibana/pull/190443","mergeCommit":{"message":"[SLOs]
Update get SLOs flaky test (#190443)\n\n## Summary\r\n\r\nfixes
https://github.com/elastic/kibana/issues/177806\r\n\r\nUpdate get SLOs
flaky test
!!","sha":"ff44bf2770bbf00479ea3a6169c892a9a2cee534"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190443","number":190443,"mergeCommit":{"message":"[SLOs]
Update get SLOs flaky test (#190443)\n\n## Summary\r\n\r\nfixes
https://github.com/elastic/kibana/issues/177806\r\n\r\nUpdate get SLOs
flaky test !!","sha":"ff44bf2770bbf00479ea3a6169c892a9a2cee534"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes v8.17.0 v9.0.0
Projects
None yet
6 participants