Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OAS] Add mute_all and unmute_all response codes #190265

Merged
merged 7 commits into from
Aug 12, 2024
Merged

[OAS] Add mute_all and unmute_all response codes #190265

merged 7 commits into from
Aug 12, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Aug 9, 2024 •
edited by kibanamachine
Loading

Summary

Relates to #189962

This PR adds the response codes and parameter descriptions for the alerting unmute all and mute all APIs.

@lcawl lcawl added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Aug 9, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl mentioned this pull request Aug 9, 2024
Merged
@lcawl lcawl marked this pull request as ready for review August 9, 2024 18:23
@lcawl lcawl requested a review from a team as a code owner August 9, 2024 18:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl
Copy link
Contributor Author

lcawl commented Aug 9, 2024

@adcoelho If you have a moment to offer advice, the logs contain the following error:

│ERROR UNHANDLED ERROR: Error: Expected a valid validation logic declared with '@kbn/config-schema' package, '@kbn/zod' package or a RouteValidationFunction at key: [response].

So it seems like simply copying the response info from https://github.com/elastic/kibana/blob/main/x-pack/plugins/alerting/server/routes/rule/apis/mute_alert/mute_alert.ts was insufficient to pass these checks.

@adcoelho
Copy link
Contributor

@lcawl

So it seems like simply copying the response info

it looks almost the same but not quite 😄 I missed it too.

I added some comments with fix suggestions.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #37 / managed content Managed Content preventing the user from overwriting managed content maps
  • [job] [logs] FTR Configs #26 / Observability AI Assistant Functional tests feature_controls/settings_security.spec.ts ai assistant management privileges all privileges displays failure toast on failed request

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 945784b into elastic:main Aug 12, 2024
38 checks passed
@lcawl lcawl deleted the alerting-responses branch August 12, 2024 15:58
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.15 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 190265

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit to lcawl/kibana that referenced this pull request Aug 12, 2024
@lcawl
[OAS] Add mute_all and unmute_all response codes (elastic#190265)
75b5200 
Co-authored-by: Antonio <[email protected]>
Co-authored-by: Jean-Louis Leysens <[email protected]>
(cherry picked from commit 945784b)
@lcawl lcawl mentioned this pull request Aug 12, 2024
Closed
@lcawl
Copy link
Contributor Author

lcawl commented Aug 12, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 13, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

4 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@lcawl lcawl added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adcoelho adcoelho adcoelho approved these changes

@jloleysens jloleysens jloleysens left review comments

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting docs Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lcawl @obltmachine @elasticmachine @adcoelho @kibana-ci @kibanamachine @jloleysens