[ES|QL] improve tokenizer and theme #190170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdaemon
force-pushed
the
fix-tokenizer
branch
from
614e737 to
e924038
Compare
drewdaemon
changed the title
|
/ci |
1 similar comment
|
/ci |
drewdaemon
added
Feature:ES|QL
|
/ci |
drewdaemon
commented
Aug 8, 2024
| } | ||
| }); | ||
|
|
||
| it('every valid lexical name should have a corresponding rule', () => { |
There was a problem hiding this comment.
Do we like this test? It seemed like a good idea as an extra check that we aren't missing some lexical token that gets added. But, we can remove if it seems like a pain.
There was a problem hiding this comment.
Yeah, leave it and let's see how painful it gets
|
/ci |
|
/ci |
drewdaemon
commented
Aug 8, 2024
Comment on lines
+61
to
+64
| 'false', // @TODO consider if this should get styling | ||
| 'true', // @TODO consider if this should get styling | ||
| 'info', // @TODO consider if this should get styling | ||
| 'colon', // @TODO consider if this should get styling |
There was a problem hiding this comment.
Does kind of feel like these should be styled somehow cc @ryankeairns
|
/ci |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-esql (Team:ESQL) |
kibanamachine
added
v8.16.0
backport:skip
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds some validation around our Monaco theme and tokenizer. I thought fixing the tokenizer would help with #187184 but it looks like providing an explicit replacement range is actually the right route.
Still, we got a few things out of this since these changes fix a few styling issues.
INLINESTATS
Casting operator
Timespan literals
Subsequent nulls last/first
MATCH
Checklist