[Telemetry][Security Solution] Fix flaky tests #190044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaffarano
added
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
szaffarano
changed the title
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 7, 2024
## Summary Fixes: elastic#188234 elastic#187719 and elastic#178918 The flakiness was while calculating the Detection Rules task invocations. It could have two different RCs: 1) The code didn't retry in case the task wasn't executed yet, which makes sense in a CI environment, which is slower than a dev environment; 2) The timestamp to filter out requests was calculated after the task was triggered, and if the task is executed fast enough, it could lead to empty responses because of that. (cherry picked from commit 358e104)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 7, 2024
) # Backport This will backport the following commits from `main` to `8.15`: - [[Telemetry][Security Solution] Fix flaky tests (#190044)](#190044) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sebastián Zaffarano","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-08-07T13:13:13Z","message":"[Telemetry][Security Solution] Fix flaky tests (#190044)\n\n## Summary\r\n\r\nFixes: https://github.com/elastic/kibana/issues/188234\r\nhttps://github.com/elastic/kibana/issues/187719 and\r\nhttps://github.com//issues/178918\r\n\r\nThe flakiness was while calculating the Detection Rules task\r\ninvocations. It could have two different RCs: 1) The code didn't retry\r\nin case the task wasn't executed yet, which makes sense in a CI\r\nenvironment, which is slower than a dev environment; 2) The timestamp to\r\nfilter out requests was calculated after the task was triggered, and if\r\nthe task is executed fast enough, it could lead to empty responses\r\nbecause of that.","sha":"358e104ebcc2bfcfeec3457b2e913d071d27745d","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: SecuritySolution","v8.15.0","v8.16.0"],"title":"[Telemetry][Security Solution] Fix flaky tests","number":190044,"url":"https://github.com/elastic/kibana/pull/190044","mergeCommit":{"message":"[Telemetry][Security Solution] Fix flaky tests (#190044)\n\n## Summary\r\n\r\nFixes: https://github.com/elastic/kibana/issues/188234\r\nhttps://github.com/elastic/kibana/issues/187719 and\r\nhttps://github.com//issues/178918\r\n\r\nThe flakiness was while calculating the Detection Rules task\r\ninvocations. It could have two different RCs: 1) The code didn't retry\r\nin case the task wasn't executed yet, which makes sense in a CI\r\nenvironment, which is slower than a dev environment; 2) The timestamp to\r\nfilter out requests was calculated after the task was triggered, and if\r\nthe task is executed fast enough, it could lead to empty responses\r\nbecause of that.","sha":"358e104ebcc2bfcfeec3457b2e913d071d27745d"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190044","number":190044,"mergeCommit":{"message":"[Telemetry][Security Solution] Fix flaky tests (#190044)\n\n## Summary\r\n\r\nFixes: https://github.com/elastic/kibana/issues/188234\r\nhttps://github.com/elastic/kibana/issues/187719 and\r\nhttps://github.com//issues/178918\r\n\r\nThe flakiness was while calculating the Detection Rules task\r\ninvocations. It could have two different RCs: 1) The code didn't retry\r\nin case the task wasn't executed yet, which makes sense in a CI\r\nenvironment, which is slower than a dev environment; 2) The timestamp to\r\nfilter out requests was calculated after the task was triggered, and if\r\nthe task is executed fast enough, it could lead to empty responses\r\nbecause of that.","sha":"358e104ebcc2bfcfeec3457b2e913d071d27745d"}}]}] BACKPORT--> Co-authored-by: Sebastián Zaffarano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #188234 #187719 and #178918
The flakiness was while calculating the Detection Rules task invocations. It could have two different RCs: 1) The code didn't retry in case the task wasn't executed yet, which makes sense in a CI environment, which is slower than a dev environment; 2) The timestamp to filter out requests was calculated after the task was triggered, and if the task is executed fast enough, it could lead to empty responses because of that.