[Dataset quality] Enable page for metrics and traces #190043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
/ci |
|
/ci |
|
/ci |
…enable-pages-for-metrics-and-traces
yngrdyn
force-pushed
the
3454-dataset-quality-enable-pages-for-metrics-and-traces
branch
from
424ef39 to
3f9fb63
Compare
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
yngrdyn
added
the
release_note:feature
yngrdyn
force-pushed
the
3454-dataset-quality-enable-pages-for-metrics-and-traces
branch
2 times, most recently
from
b4a7e37 to
1a6a1d0
Compare
yngrdyn
force-pushed
the
3454-dataset-quality-enable-pages-for-metrics-and-traces
branch
from
1a6a1d0 to
ae42b56
Compare
…enable-pages-for-metrics-and-traces
achyutjhunjhunwala
approved these changes
Aug 22, 2024
…s' of github.com:yngrdyn/kibana into 3454-dataset-quality-enable-pages-for-metrics-and-traces
yngrdyn
force-pushed
the
3454-dataset-quality-enable-pages-for-metrics-and-traces
branch
3 times, most recently
from
a6de1be to
4d346f5
Compare
yngrdyn
force-pushed
the
3454-dataset-quality-enable-pages-for-metrics-and-traces
branch
from
11242d5 to
17fa51c
Compare
…s' of github.com:yngrdyn/kibana into 3454-dataset-quality-enable-pages-for-metrics-and-traces
…enable-pages-for-metrics-and-traces
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.16.0
backport:skip
yngrdyn
added a commit
that referenced
this pull request
Sep 2, 2024
…taset when no type is selected in the UI (#191895) In #190043 we enabled `GET /internal/dataset_quality/data_streams/stats` and `GET /internal/dataset_quality/data_streams/non_aggregatable` for work with multiple dataStream types, but we left out the case where in the UI no type is selected. The solution is the same we applied to [`GET /internal/dataset_quality/data_streams/stats`](https://github.com/yngrdyn/kibana/blob/b1f9e290213368e550ab692124a419683409c937/x-pack/plugins/observability_solution/dataset_quality/public/services/data_streams_stats/data_streams_stats_client.ts#L38), when no type is selected in the UI we should send all known types. ### Before https://github.com/user-attachments/assets/da83c3c2-6d6d-4401-bd12-99d6ab1da7ea ### After https://github.com/user-attachments/assets/cf17594f-d4a9-4d83-8a9a-6252e102b475
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/observability-dev/issues/3454.
This PR enables Dataset quality for being used for
tracesandmetrics.Changes
KNOWN_TYPESarray containing the types that we allow in dataset quality page.datasets,degradedDocsandnonAggregatableDatasetsare now wrapped in an state. This allow us to retrigger the calls whenever we need to do it (e.g. when changing timeframe), more importantly now whenever we select a new type of dataset.invokedegradedDocsis created dynamically depending on the types present inKNOWN_TYPES.GET /internal/dataset_quality/data_streams/statsandGET /internal/dataset_quality/data_streams/non_aggregatablenow accept an array ofDataStreamType. This allow us to query the information for multiple types of dataStreams at the same time.🎥 Demo
Screen.Recording.2024-08-20.at.14.10.15.mov