Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade FullStory snippet #189960

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Upgrade FullStory snippet #189960

merged 5 commits into from
Aug 23, 2024

Conversation

afharo
Copy link
Member

@afharo afharo commented Aug 6, 2024

Summary

- CompiledVersion:"11aa377d19",CompiledTimestamp:1678707725 // 2023-03-23
+ CompiledVersion:"02de958fc73c1c50dec6d324a9487bc6a363c081",CompiledTimestamp:1722436201 // 2024-07-31

It's been more than 1 year since we updated, and we don't want to risk an "oh no, data stopped flowing" situation (#153570).

cc @elastic/cloud-ui @elastic/platform-onboarding as you may want to update yours as well.

cc @shahinakmal @elastic/platform-analytics for awareness

cc @elastic/kibana-security for any audit required

For maintainers

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Journey/Onboarding Platform Journey Onboarding team labels Aug 6, 2024
@afharo afharo requested review from a team August 6, 2024 10:13
@afharo afharo self-assigned this Aug 6, 2024
@afharo afharo requested a review from a team as a code owner August 6, 2024 10:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@afharo afharo added ci:cloud-deploy Create or update a Cloud deployment ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project ci:project-deploy-observability Create an Observability project ci:project-deploy-security Create a Security Serverless Project labels Aug 6, 2024
@afharo afharo marked this pull request as draft August 6, 2024 11:14
@afharo
Copy link
Member Author

afharo commented Aug 6, 2024

Converting to draft, it looks like the new snippet comes with v2, which includes a lot of breaking changes:
https://developer.fullstory.com/browser/getting-started/#whats-new-in-version-2

  1. Type annotations are dropped (instead of version_str, we can now report version and, optionally, annotate it via the schema attribute: https://developer.fullstory.com/browser/custom-properties/
  2. APIs have been renamed (although v1 are still supported):

@afharo
Copy link
Member Author

afharo commented Aug 6, 2024

I created elastic/ebt#2 to update the client. Once published, I'll update it here.

@afharo afharo marked this pull request as ready for review August 9, 2024 10:16
@afharo
Copy link
Member Author

afharo commented Aug 9, 2024

I created elastic/ebt#2 to update the client. Once published, I'll update it here.

Since the current APIs are deprecated but still usable, I'll push this one forward to avoid leaving it hanging for too long, and renovate will update the package when published.

Copy link
Contributor

@elena-shostak elena-shostak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no vulnerabilities for v2.
LGTM!

Copy link
Contributor

@gsoldevila gsoldevila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review only)

@afharo afharo enabled auto-merge (squash) August 23, 2024 15:39
@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 23, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #87 / Cloud Security Posture Test adding Cloud Security Posture Integrations CSPM GCP CIS_GCP Single Users are able to add CIS_GCP Integration with Manual settings using Credentials JSON

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afharo

@afharo afharo merged commit 9ab690e into elastic:main Aug 23, 2024
27 checks passed
@afharo afharo deleted the upgrade-fs-snippet branch August 23, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project ci:project-deploy-observability Create an Observability project ci:project-deploy-security Create a Security Serverless Project release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Journey/Onboarding Platform Journey Onboarding team Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants