Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDR Workflows] Remove automated actions old feature flags #189954

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

tomsonpl
Copy link
Contributor

@tomsonpl tomsonpl commented Aug 6, 2024

This PR removes two feature flags:

  • responseActionsEnabled added in 8.5.0
  • endpointResponseActionsEnabled added in 8.9.0
    And also a not used anymore osquery_tab component

This flag still stays in place: automatedProcessActionsEnabled

@tomsonpl tomsonpl self-assigned this Aug 6, 2024
@tomsonpl
Copy link
Contributor Author

tomsonpl commented Aug 6, 2024

/ci

@tomsonpl tomsonpl added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.16.0 labels Aug 6, 2024
@tomsonpl tomsonpl marked this pull request as ready for review August 6, 2024 11:13
@tomsonpl tomsonpl requested review from a team as code owners August 6, 2024 11:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@tomsonpl tomsonpl requested review from e40pud and maximpn August 6, 2024 11:13
@tomsonpl
Copy link
Contributor Author

tomsonpl commented Aug 6, 2024

/ci

Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning these!
Funny enough I was looking at the experimental_features files a couple of days ago and was about to ping the teams that had a feature flag set to true by default to ask if these could be removed. 😄

Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule Management LGTM

@tomsonpl
Copy link
Contributor Author

tomsonpl commented Aug 9, 2024

/ci

@tomsonpl tomsonpl enabled auto-merge (squash) August 9, 2024 09:28
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 5649 5648 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.7MB 20.7MB -10.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 86.2KB 86.1KB -60.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tomsonpl

@tomsonpl tomsonpl merged commit 813025c into elastic:main Aug 9, 2024
39 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants