Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Cases] Fix custom fields flaky test. #189475

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

adcoelho
Copy link
Contributor

fixes #188133

Summary

I simplified the failing test a bit to make it less likely to timeout.

  1. We checked for the test and the id to make sure the component was rendered, it was redundant.
  2. We looked for all custom fields(4) and I reduced the check to just 2(which have different types).
  3. Updated another test that looked for a label to look for an id(for consistency).

@adcoelho adcoelho added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.16.0 labels Jul 30, 2024
@adcoelho adcoelho self-assigned this Jul 30, 2024
@adcoelho adcoelho requested a review from a team as a code owner July 30, 2024 08:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @adcoelho

@adcoelho adcoelho merged commit 60e1257 into elastic:main Jul 31, 2024
30 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.16.0
Projects
None yet
5 participants