Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM][ECO] Consistent CTA and URL for adding APM data in the new experience #189349

Merged
merged 5 commits into from
Jul 29, 2024
Merged

[APM][ECO] Consistent CTA and URL for adding APM data in the new experience #189349

merged 5 commits into from
Jul 29, 2024

Conversation

kpatticha
Copy link
Contributor

Summary

closes #188833

  1. Add APM will point to the new onboarding link: app/observabilityOnboarding/?category=apm
  2. Opens at the same tab

Empty state

Screen.Recording.2024-07-29.at.11.08.12.mov
Screen.Recording.2024-07-29.at.11.07.31.mov

@kpatticha kpatticha requested a review from a team as a code owner July 29, 2024 08:22
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Jul 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kpatticha kpatticha added release_note:skip Skip the PR/issue when compiling release notes v8.16.0 labels Jul 29, 2024
cauemarcondes
cauemarcondes approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpatticha kpatticha enabled auto-merge (squash) July 29, 2024 09:12
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jul 29, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB -192.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kpatticha kpatticha merged commit 3639a5d into elastic:main Jul 29, 2024
23 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

@jennypavlova jennypavlova jennypavlova approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM][ECO] Consistent CTA for adding apm data
7 participants
@kpatticha @elasticmachine @obltmachine @kibana-ci @jennypavlova @cauemarcondes @kibanamachine