[ES|QL] remove meta #189302
Merged
[ES|QL] remove meta #189302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
drewdaemon
added
release_note:skip
|
/ci |
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
approved these changes
Jul 29, 2024
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 29, 2024
## Summary close elastic#188481 `META` is still in the grammar so you won't get a syntax error, but no highlighting, validation, or autocomplete support. <img width="268" alt="Screenshot 2024-07-26 at 9 46 09 AM" src="https://github.com/user-attachments/assets/563ba2fe-c35d-437e-bc6c-e717cd8b0de8"> --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 49fb36c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 29, 2024
# Backport This will backport the following commits from `main` to `8.15`: - [[ES|QL] remove meta (#189302)](#189302) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-29T16:31:34Z","message":"[ES|QL] remove meta (#189302)\n\n## Summary\r\n\r\nclose https://github.com/elastic/kibana/issues/188481\r\n\r\n`META` is still in the grammar so you won't get a syntax error, but no\r\nhighlighting, validation, or autocomplete support.\r\n\r\n<img width=\"268\" alt=\"Screenshot 2024-07-26 at 9 46 09 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/563ba2fe-c35d-437e-bc6c-e717cd8b0de8\">\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"49fb36c69c780e947bf95d67b0e012a2fcde63e3","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.15.0","v8.16.0"],"title":"[ES|QL] remove meta","number":189302,"url":"https://github.com/elastic/kibana/pull/189302","mergeCommit":{"message":"[ES|QL] remove meta (#189302)\n\n## Summary\r\n\r\nclose https://github.com/elastic/kibana/issues/188481\r\n\r\n`META` is still in the grammar so you won't get a syntax error, but no\r\nhighlighting, validation, or autocomplete support.\r\n\r\n<img width=\"268\" alt=\"Screenshot 2024-07-26 at 9 46 09 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/563ba2fe-c35d-437e-bc6c-e717cd8b0de8\">\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"49fb36c69c780e947bf95d67b0e012a2fcde63e3"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189302","number":189302,"mergeCommit":{"message":"[ES|QL] remove meta (#189302)\n\n## Summary\r\n\r\nclose https://github.com/elastic/kibana/issues/188481\r\n\r\n`META` is still in the grammar so you won't get a syntax error, but no\r\nhighlighting, validation, or autocomplete support.\r\n\r\n<img width=\"268\" alt=\"Screenshot 2024-07-26 at 9 46 09 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/563ba2fe-c35d-437e-bc6c-e717cd8b0de8\">\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"49fb36c69c780e947bf95d67b0e012a2fcde63e3"}}]}] BACKPORT--> Co-authored-by: Drew Tate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close #188481
METAis still in the grammar so you won't get a syntax error, but no highlighting, validation, or autocomplete support.