Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EDR Workflows] Reenable and improve endpoint FTR tests on serverless #189248

Merged
merged 15 commits into from
Aug 5, 2024
Merged

[EDR Workflows] Reenable and improve endpoint FTR tests on serverless #189248

merged 15 commits into from
Aug 5, 2024
+70 −131

Conversation

gergoabraham
Copy link
Contributor

@gergoabraham gergoabraham commented Jul 26, 2024 •
edited by kibanamachine
Loading

Summary

This PR re-enables our endpoint FTRs, and tries to address the serverless login/forceLogout flakiness both in endpoint and integration FTRs, by using a new svlCommonPage.loginWithRole() login functionality, suggested in this comment: #184202 (comment)

flaky runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6678

closes: #186089
closes: #186086

@gergoabraham gergoabraham added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jul 26, 2024
@gergoabraham gergoabraham self-assigned this Jul 26, 2024
@gergoabraham gergoabraham mentioned this pull request Jul 26, 2024
Merged
@gergoabraham
Copy link
Contributor Author

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6633

[❌] x-pack/test/security_solution_endpoint/configs/serverless.integrations.config.ts: 0/25 tests passed.
[✅] x-pack/test/security_solution_endpoint/configs/serverless.endpoint.config.ts: 25/25 tests passed.

see run history

@gergoabraham gergoabraham force-pushed the reenable-and-improve-endpont-ftr-tests-on-serverless branch from f8d2386 to a25bd6d Compare July 29, 2024 12:19
@gergoabraham
Copy link
Contributor Author

/ci

1 similar comment
@gergoabraham
Copy link
Contributor Author

/ci

@gergoabraham gergoabraham force-pushed the reenable-and-improve-endpont-ftr-tests-on-serverless branch from 0ccf506 to 248e027 Compare July 30, 2024 09:14
@gergoabraham
Copy link
Contributor Author

/ci

@gergoabraham gergoabraham force-pushed the reenable-and-improve-endpont-ftr-tests-on-serverless branch from 577aad3 to 8a306c4 Compare July 30, 2024 13:43
@gergoabraham
Copy link
Contributor Author

/ci

@gergoabraham
Copy link
Contributor Author

@elasticmachine merge upstream

@gergoabraham
Copy link
Contributor Author

/ci

@gergoabraham
Copy link
Contributor Author

/ci

@gergoabraham
Copy link
Contributor Author

/ci

@gergoabraham gergoabraham changed the title [EDR Workflows] Reenable and improve endpont FTR tests on serverless [EDR Workflows] Reenable and improve endpoint FTR tests on serverless Aug 5, 2024
@gergoabraham
Copy link
Contributor Author

@elasticmachine merge upstream

@gergoabraham
Copy link
Contributor Author

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6678

[✅] x-pack/test/security_solution_endpoint/configs/serverless.integrations.config.ts: 25/25 tests passed.
[✅] x-pack/test/security_solution_endpoint/configs/serverless.endpoint.config.ts: 25/25 tests passed.

see run history

@gergoabraham gergoabraham marked this pull request as ready for review August 5, 2024 12:32
@gergoabraham gergoabraham requested review from a team as code owners August 5, 2024 12:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

szwarckonrad
szwarckonrad reviewed Aug 5, 2024
View reviewed changes
x-pack/test/security_solution_endpoint/configs/config.base.ts Outdated
@@ -41,6 +41,7 @@ export const generateConfig = async ({
kbnServerArgs?: string[];
target: keyof typeof SUITE_TAGS;
services: any;
pageObjects: any;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6213420

szwarckonrad
szwarckonrad approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@szwarckonrad szwarckonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for addressing this.

@gergoabraham gergoabraham enabled auto-merge (squash) August 5, 2024 16:38
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @gergoabraham

@gergoabraham gergoabraham merged commit 52aea61 into elastic:main Aug 5, 2024
18 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.15 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.15:
- [Obs AI Assistant] Add ES function API test (#187465)

Manual backport

To create the backport manually run:

node scripts/backport --pr 189248

Questions ?

Please refer to the Backport tool documentation

@gergoabraham
Copy link
Contributor Author

💔 All backports failed

Status Branch Result
❌ 8.15 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.15:

Manual backport

To create the backport manually run:

node scripts/backport --pr 189248

Questions ?

Please refer to the Backport tool documentation

nah, it's not worth to merge it to 8.15 manually and fixing conflits, as this PR only affects serverless testing, which is only relevant to the main branch

@gergoabraham gergoabraham deleted the reenable-and-improve-endpont-ftr-tests-on-serverless branch August 6, 2024 08:06
@gergoabraham gergoabraham added backport:skip This commit does not require backporting and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwarckonrad szwarckonrad szwarckonrad approved these changes

@joeypoon joeypoon joeypoon approved these changes

Assignees

@gergoabraham gergoabraham

Labels
backport:skip This commit does not require backporting OLM Sprint release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.16.0
Projects
None yet
Milestone
No milestone
6 participants
@gergoabraham @kibanamachine @elasticmachine @kibana-ci @joeypoon @szwarckonrad