Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Enable cell range selection. #18920

Merged
merged 1 commit into from
May 9, 2018
Merged

[ML] Enable cell range selection. #18920

merged 1 commit into from
May 9, 2018

Conversation

walterra
Copy link
Contributor

@walterra walterra commented May 8, 2018

This re-enables the feature flag to support selecting a range of cells in the anomaly explorer for 6.4.

Follow-ups to this PR will tackle limiting the allowed cells to select to avoid problems with too wide selections.

drag-select

@walterra walterra self-assigned this May 8, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

jgowdyelastic
jgowdyelastic approved these changes May 9, 2018
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes May 9, 2018
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling the flag LGTM. The work to limit cell range selection is needed before getting this in for 6.4 to ensure all anomalies in the selected swimlane cells can be viewed in the charts plotted at bucket span granularity.

@peteharverson
Copy link
Contributor

Here's an example where dragging across a wide time range compared to the bucket span of the job can lead to potentially confusing charts. The selection goes across three red swimlane cells, but the chart only shows one red dot at the extreme right of the chart.

image

@walterra walterra merged commit 79c4d4e into elastic:master May 9, 2018
@walterra walterra deleted the ml-enable-call-range-selection branch May 9, 2018 13:12
walterra added a commit to walterra/kibana that referenced this pull request May 9, 2018
@walterra
[ML] Enable cell range selection. (elastic#18920)
d1ff621 
This re-enables the feature flag to support selecting a range of cells in the anomaly explorer. Follow-ups to this PR will tackle limiting the allowed cells to select to avoid problems with too wide selections.
@walterra walterra mentioned this pull request May 9, 2018
Merged
walterra added a commit that referenced this pull request May 9, 2018
@walterra
[ML] Enable cell range selection. (#18920) (#18950)
1fd0f7a 
This re-enables the feature flag to support selecting a range of cells in the anomaly explorer. Follow-ups to this PR will tackle limiting the allowed cells to select to avoid problems with too wide selections.
@peteharverson peteharverson mentioned this pull request May 11, 2018
Merged
@peteharverson peteharverson mentioned this pull request May 24, 2018
Merged
@sophiec20 sophiec20 added the Feature:Anomaly Detection ML anomaly detection label Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@walterra walterra

Labels
Feature:Anomaly Detection ML anomaly detection Feature:ml-results legacy - do not use :ml v6.4.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@walterra @elasticmachine @peteharverson @jgowdyelastic @sophiec20