-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Fix namespaces property of created agent policies #189199
[Fleet] Fix namespaces property of created agent policies #189199
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this 🚀
/ci |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
@nchaulet Should this be backported to 8.15.0? |
I am not sure there is any value to backport it, it should not create any bugs with the feature flag disabled, and I do not think we expect to turn the flag on in 8.15.0 |
Summary
I found a small bug while working on #185040: when agent policies are created, there should be a root-level
namespaces
property, which is currently missing.GET .fleet-policies/_mapping
contains anamespaces
property withkeyword
type that was added in https://github.com/elastic/elasticsearch.Note: I was looking into removing the existing
data.namespaces
property, however I don't see any issues with it. It is coming from here, i.e. thedata
property is generated from the full agent policy which already has anamespaces
property.Checklist