Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix namespaces property of created agent policies #189199

Merged

Conversation

jillguyonnet
Copy link
Contributor

@jillguyonnet jillguyonnet commented Jul 25, 2024

Summary

I found a small bug while working on #185040: when agent policies are created, there should be a root-level namespaces property, which is currently missing.

GET .fleet-policies/_mapping contains a namespaces property with keyword type that was added in https://github.com/elastic/elasticsearch.

Note: I was looking into removing the existing data.namespaces property, however I don't see any issues with it. It is coming from here, i.e. the data property is generated from the full agent policy which already has a namespaces property.

Checklist

@jillguyonnet jillguyonnet self-assigned this Jul 25, 2024
@jillguyonnet jillguyonnet added the Team:Fleet Team label for Observability Data Collection Fleet team label Jul 25, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@jillguyonnet jillguyonnet added the release_note:skip Skip the PR/issue when compiling release notes label Jul 25, 2024
@jillguyonnet jillguyonnet requested a review from nchaulet July 25, 2024 15:04
@jillguyonnet jillguyonnet marked this pull request as ready for review July 25, 2024 15:04
@jillguyonnet jillguyonnet requested a review from a team as a code owner July 25, 2024 15:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 🚀

@jillguyonnet
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jillguyonnet

@jillguyonnet
Copy link
Contributor Author

@nchaulet Should this be backported to 8.15.0?

@nchaulet
Copy link
Member

@nchaulet Should this be backported to 8.15.0?

I am not sure there is any value to backport it, it should not create any bugs with the feature flag disabled, and I do not think we expect to turn the flag on in 8.15.0

@jillguyonnet jillguyonnet merged commit 9bc5741 into elastic:main Jul 26, 2024
20 checks passed
@jillguyonnet jillguyonnet deleted the fleet/fix-agent-policy-space-aware branch July 26, 2024 12:40
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants