[FTR] Refactor test/common/services/* -> packages/kbn-ftr-common-functional-[ui-]services/* #189051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayneseymour
added
release_note:skip
wayneseymour
changed the title
test/common/services/* -> packages/kbn-ftr-common-functional-[ui]-servicestest/common/services/* -> packages/kbn-ftr-common-functional-[ui]-services/*
wayneseymour
changed the title
test/common/services/* -> packages/kbn-ftr-common-functional-[ui]-services/*
|
/ci |
wayneseymour
force-pushed
the
ftr/refactor-test-common-services
branch
from
b6d8466 to
8a1f919
Compare
|
/ci |
wayneseymour
force-pushed
the
ftr/refactor-test-common-services
branch
from
8b8c0fb to
5b16ca2
Compare
|
/ci |
1 similar comment
|
/ci |
5 tasks
wayneseymour
force-pushed
the
ftr/refactor-test-common-services
branch
from
526ce5c to
7d256d1
Compare
|
/ci |
wayneseymour
force-pushed
the
ftr/refactor-test-common-services
branch
from
7d256d1 to
54c49d2
Compare
|
/ci |
wayneseymour
changed the title
|
/ci |
wayneseymour
force-pushed
the
ftr/refactor-test-common-services
branch
from
15e4641 to
571549d
Compare
|
/ci |
wayneseymour
force-pushed
the
ftr/refactor-test-common-services
branch
from
571549d to
2a54f3c
Compare
|
/ci |
wayneseymour
force-pushed
the
ftr/refactor-test-common-services
branch
from
06b3a76 to
2dd1322
Compare
|
/ci |
1 similar comment
|
/ci |
wayneseymour
force-pushed
the
ftr/refactor-test-common-services
branch
from
e1bfc51 to
abc07f9
Compare
|
/ci |
1 similar comment
|
/ci |
wayneseymour
force-pushed
the
ftr/refactor-test-common-services
branch
from
66ee4c9 to
af59b80
Compare
|
/ci |
|
@elasticmachine merge upstream |
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
davismcphee
approved these changes
Aug 27, 2024
opauloh
approved these changes
Aug 27, 2024
Ikuni17
approved these changes
Aug 27, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Public APIs missing comments
Public APIs missing exports
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
PhilippeOberti
approved these changes
Aug 28, 2024
sabarasaba
approved these changes
Aug 28, 2024
hop-dev
approved these changes
Aug 28, 2024
juliaElastic
approved these changes
Aug 28, 2024
angorayc
approved these changes
Aug 28, 2024
jennypavlova
approved these changes
Aug 28, 2024
dmlemeshko
reviewed
Aug 29, 2024
There was a problem hiding this comment.
question: shouldn't we put security service in kbn-ftr-common-functional-services ?
I don't think it has any dependency on browser / Kibana UI and is used in both api_integration and functional test.
There was a problem hiding this comment.
nvm, TestUser services is relying on Browser service.
There was a problem hiding this comment.
You're fast dude! I was just copying the link to that! lol
dmlemeshko
approved these changes
Aug 29, 2024
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Aug 29, 2024
…mon-functional-[ui-]services/* (elastic#189051)" This reverts commit 09a3658.
|
This was reverted in #191765. See https://buildkite.com/elastic/kibana-pull-request/builds/230868#01919ed7-15d5-425c-9b8e-146ed5fe9daf for the build failure. |
wayneseymour
added a commit
that referenced
this pull request
Sep 5, 2024
…tional-[ui-]services/* (#191805) ## Summary Moving common services to respective new homes. This PR is revived from a previously [merged](09a3658) and [reverted PR](#191765) as [detailed here](#189051 (comment)). - This was due to "extra" tests being applied to #191708 - These "extra" tests were applied as #191708 changes files within `x-pack/plugins/observability_solution/` as configured [here](https://github.com/elastic/kibana/blob/main/.buildkite/scripts/pipelines/pull_request/pipeline.ts#L129) ### Why these failures were not caught in the original [PR](#189051) The pipeline is generated at runtime, and the original [PR](#189051) had zero changes under `x-pack/plugins/observability_solution/` ## Changes on top of original PR - Add `ci:all-cypress-suites` label to run extra tests - Add `services` stanza to which contains the missing references by spreading the services from `@kbn/ftr-common-functional-services` && `@kbn/ftr-common-functional-ui-services` into the stanza, for the following: - `x-pack/plugins/observability_solution/synthetics/e2e/config.ts` - `x-pack/plugins/observability_solution/apm/ftr_e2e/ftr_config.ts` - `x-pack/plugins/observability_solution/observability_onboarding/e2e/ftr_config.ts` - `x-pack/plugins/observability_solution/profiling/e2e/ftr_config.ts` - `x-pack/plugins/observability_solution/synthetics/e2e/config.ts` - `x-pack/plugins/observability_solution/uptime/e2e/config.ts` Blocked by: #191961 Resolves: #188541 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moving common services to respective new homes.
Resolves: #188541