Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard][ES|QL] Unable to load page error on edit/add ES|QL panel #188664

Merged
merged 3 commits into from
Jul 22, 2024
Merged

[Dashboard][ES|QL] Unable to load page error on edit/add ES|QL panel #188664

merged 3 commits into from
Jul 22, 2024

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Jul 18, 2024 •
edited by kibanamachine
Loading

Summary

Fixes #184544

@mbondyra mbondyra added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 labels Jul 18, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +28.0B

@mbondyra mbondyra force-pushed the lens/fix_breaking_flyout branch from e583c70 to 5c42edc Compare July 19, 2024 08:34
@mbondyra mbondyra marked this pull request as ready for review July 19, 2024 08:34
@mbondyra mbondyra requested a review from a team as a code owner July 19, 2024 08:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

nickofthyme
nickofthyme approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirms this fixes issue 👍🏼

x-pack/plugins/lens/public/visualizations/metric/dimension_editor.tsx
@@ -131,7 +131,7 @@ function MaximumEditor({ setState, state, idPrefix }: SubProps) {
}

function SecondaryMetricEditor({ accessor, idPrefix, frame, layerId, setState, state }: SubProps) {
const columnName = getColumnByAccessor(accessor, frame.activeData?.[layerId].columns)?.name;
const columnName = getColumnByAccessor(accessor, frame.activeData?.[layerId]?.columns)?.name;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is why we enabled noUncheckedIndexedAccess in @elastic/charts elastic/elastic-charts#2006.

That way any array access is treated as a union with undefined unless the type is an explicit tuple.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! It'd be good to add it in Kibana, we had some bugs in the past caused by it.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +28.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra mbondyra merged commit b7b3260 into elastic:main Jul 22, 2024
19 checks passed
@mbondyra mbondyra deleted the lens/fix_breaking_flyout branch July 22, 2024 14:59
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 22, 2024
@mbondyra
[Dashboard][ES|QL] Unable to load page error on edit/add ES|QL panel (e…
da23fd1 
…lastic#188664)

## Summary

Fixes elastic#184544

(cherry picked from commit b7b3260)
@kibanamachine kibanamachine mentioned this pull request Jul 22, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 22, 2024
@kibanamachine @mbondyra
[8.15] [Dashboard][ES|QL] Unable to load page error on edit/add ES|QL…
5536a95 
… panel (#188664) (#188857)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Dashboard][ES|QL] Unable to load page error on edit/add ES|QL panel
(#188664)](#188664)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marta
Bondyra","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-22T14:59:40Z","message":"[Dashboard][ES|QL]
Unable to load page error on edit/add ES|QL panel (#188664)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/184544","sha":"b7b3260db2b150911f283351655a721d7f16e711","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:prev-minor","v8.16.0"],"title":"[Dashboard][ES|QL]
Unable to load page error on edit/add ES|QL
panel","number":188664,"url":"https://github.com/elastic/kibana/pull/188664","mergeCommit":{"message":"[Dashboard][ES|QL]
Unable to load page error on edit/add ES|QL panel (#188664)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/184544","sha":"b7b3260db2b150911f283351655a721d7f16e711"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188664","number":188664,"mergeCommit":{"message":"[Dashboard][ES|QL]
Unable to load page error on edit/add ES|QL panel (#188664)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/184544","sha":"b7b3260db2b150911f283351655a721d7f16e711"}}]}]
BACKPORT-->

Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.15.0 v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dashboard][ES|QL] Unable to load page error on edit/add ES|QL panel
5 participants
@mbondyra @elasticmachine @kibana-ci @kibanamachine @nickofthyme