[ResponseOps][Rules] Version disable rule route #188659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcoelho
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
💚 Build Succeeded
Metrics [docs]
History
cc @adcoelho |
umbopepato
approved these changes
Jul 22, 2024
cnasikas
approved these changes
Jul 22, 2024
| @@ -585,6 +585,16 @@ describe('disable()', () => { | |||
| expect(taskManager.removeIfExists).not.toHaveBeenCalledWith(); | |||
| }); | |||
|
|
|||
| test('throws if API params do not match the schema', async () => { | |||
There was a problem hiding this comment.
super nit: should we also validate the untrack param?
JiaweiWu
reviewed
Jul 22, 2024
|
|
||
| import { schema } from '@kbn/config-schema'; | ||
|
|
||
| export const disableRuleRequestBodySchema = schema.nullable( |
There was a problem hiding this comment.
nitpick: we can give this entire body schema a default value so we wouldn't have to check for null in the route level
| const { id } = req.params; | ||
| const { untrack = false } = req.body || {}; | ||
| const { id }: DisableRuleRequestParamsV1 = req.params; | ||
| const body: DisableRuleRequestBodyV1 = req.body || {}; |
There was a problem hiding this comment.
The comment above is referring to this
| try { | ||
| await rulesClient.disable({ id, untrack }); | ||
| await rulesClient.disable(disableParams); |
There was a problem hiding this comment.
let's rename this to disableRule, so disable.ts -> disable_rule.ts
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @adcoelho |
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Parent Issue: #187572
Versions the
POST /rule/{id}/_disableendpoint.Checklist