-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate UI cleanup #188639
Investigate UI cleanup #188639
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
39d82a1
to
d8f4d7d
Compare
<EuiFlexItem grow={false} className={sideBarClassName}> | ||
<EuiFlexGroup direction="column" gutterSize="m"> | ||
<EuiFlexItem className={gridContainerClassName} grow={false}> | ||
<InvestigateWidgetGrid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved the InvestigateWidgetGrid to the sidebar, so that added notes appear on the sidebar.
TODO: Once we add the other widgets (ESQL, embeddable) in the UI, we need to rethink the InvestigateWidgetGrid, because now all widgets (included notes) appear in one common timeline. That's not what we want in the mock up design
Fixes #188582
This PR can be merged after this PR is merged and should be rebased with main.
This is how the UI looks like. It will be properly styled as part of the smaller subtasks defined in this ticket.
cc @kdelemme