Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate UI cleanup #188639

Closed
wants to merge 23 commits into from
Closed

Conversation

mgiota
Copy link
Contributor

@mgiota mgiota commented Jul 18, 2024

Fixes #188582

This PR can be merged after this PR is merged and should be rebased with main.

This is how the UI looks like. It will be properly styled as part of the smaller subtasks defined in this ticket.

  • Notes widget was moved on the sidebar
  • A new "Add observation chart" button was added
  • A few components were removed from the page like minitimeline, minimap, investigate_search_bar, investigate_detail (undo/redo), investigate_history
Screenshot 2024-07-18 at 14 29 59

cc @kdelemme

Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mgiota mgiota force-pushed the investigate-ui-cleanup branch from 39d82a1 to d8f4d7d Compare July 18, 2024 12:28
@mgiota mgiota self-assigned this Jul 18, 2024
<EuiFlexItem grow={false} className={sideBarClassName}>
<EuiFlexGroup direction="column" gutterSize="m">
<EuiFlexItem className={gridContainerClassName} grow={false}>
<InvestigateWidgetGrid
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the InvestigateWidgetGrid to the sidebar, so that added notes appear on the sidebar.

TODO: Once we add the other widgets (ESQL, embeddable) in the UI, we need to rethink the InvestigateWidgetGrid, because now all widgets (included notes) appear in one common timeline. That's not what we want in the mock up design

@mgiota
Copy link
Contributor Author

mgiota commented Jul 19, 2024

Update
Here's the visual state of current PR

Screenshot 2024-07-19 at 21 54 28

There is no design applied to the UI yet. It brings the investigate-app from this POC with a few components deleted. Goal of this PR is to have the investigate-app being merged, so that more people can start working on the smaller tasks defined here.

@mgiota mgiota closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RCA][Investigation detail page] Clean up the investigate-app UI
4 participants