Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] [Inline editing] Flyout gets too big fix #188451

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Jul 16, 2024

Summary

Fixes #188330

Caused by eui upgrade: elastic/eui@b1370af

It's an ugly solution, but I couldn't find any other :(

After the fix:

Screenshot 2024-07-16 at 17 09 44

@mbondyra mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v8.16.0 labels Jul 16, 2024
@mbondyra mbondyra requested a review from a team as a code owner July 16, 2024 14:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@mbondyra mbondyra enabled auto-merge (squash) July 16, 2024 15:10
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +118.0B

@mbondyra mbondyra merged commit e53712d into elastic:main Jul 16, 2024
30 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.16.0
Projects
None yet
4 participants