[APM] Fix condition for enabling isEntityCentricExperienceView

[kpatticha]

fixes https://github.com/elastic/observability-dev/issues/3736

Summary

Initially, the new entity experience view was enabled if the entity data transform was activated.

However, this is not the desired behavior: when reverting to the classic view, the entity definition was being deleted. Return to the classic view should only affect the individual user.

• The entity definition resides on the cluster.
• The entity centric experience feature flag is set per space.
• The entity view is set per browser.

Changes

• The new view (isEntityCentricExperienceViewEnabled) is now determined by checking entity manager enablement, feature flag, and local storage.
• Restoring the classic view no longer deletes the data transforms.

Screen.Recording.2024-07-15.at.20.26.36.mov

[elasticmachine]

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

[obltmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[cauemarcondes]

LGTM

[kibanamachine]

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6555

[❌] APM - Cypress: 0/2 tests passed.

see run history

[kibanamachine]

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6557

[❌] APM - Cypress: 0/10 tests passed.

see run history

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: ee020a1
• Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-188343-ee020a16ee97
• Observability Deployment

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
apm	3.5MB	3.5MB	+668.0B

History

• 💔 Build #221801 failed 2407ce1
• 💔 Build #221711 failed a1fad6d
• 💔 Build #221662 failed 8d6db37
• 💔 Build #221551 failed 450be66

[roshan-elastic]

Hey @kpatticha, quick question...

Look at the PR description it confirms that one user clicking 'return to classic' will not turn off EEM for the cluster (and other users can still leverage the new experience).

The video shows a slightly different journey where the user turns off the feature flag (vs someone clicking 'return to classic').

I just wanted to confirm that for a cluster running the EEM transforms, if a user 'returns to classic' then other users will still continue to be able to enjoy the new experience (because the transforms are still running)?

I'm 99% sure the answer is 'yes' but just double-checking.

[kpatticha]

@roshan-elastic Yes, 'returns to classic' no longer deletes the data transforms

Screen.Recording.2024-07-17.at.12.19.12.mov