[eem] add option to delete indices when deleting definition #188116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klacabane
added
release_note:skip
|
Pinging @elastic/obs-knowledge-team (Team:obs-knowledge) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
klacabane
commented
Jul 11, 2024
| @@ -25,7 +24,7 @@ export function checkEntityDiscoveryEnabledRoute<T extends RequestHandlerContext | |||
| server, | |||
| logger, | |||
| }: SetupRouteOptions<T>) { | |||
| router.get<unknown, unknown, ManagedEntityEnabledResponse>( | |||
There was a problem hiding this comment.
wrongly assumed this parameter to be the response type instead of the body type
miltonhultgren
approved these changes
Jul 11, 2024
Comment on lines
+29
to
+33
| validate: { | ||
| query: schema.object({ | ||
| deleteData: schema.maybe(schema.boolean({ defaultValue: false })), | ||
| }), | ||
| }, |
There was a problem hiding this comment.
Can we convert this to zod instead? Since that's what we're using for the other endpoints
There was a problem hiding this comment.
sure, logged #188171
Comment on lines
+29
to
+31
| query: schema.object({ | ||
| deleteData: schema.maybe(schema.boolean({ defaultValue: false })), | ||
| }), |
💚 Build Succeeded
Metrics [docs]
History
cc @klacabane |
kibanamachine
added
v8.16.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to delete indices when deleting definition