Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssl.redirectHttpFromPort: use host from request instead of config #188088

Merged
merged 2 commits into from
Jul 12, 2024
Merged

ssl.redirectHttpFromPort: use host from request instead of config #188088

merged 2 commits into from
Jul 12, 2024

Conversation

pgayvallet
Copy link
Contributor

Summary

Fix #24870

@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.16.0 labels Jul 11, 2024
@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet pgayvallet marked this pull request as ready for review July 11, 2024 13:39
@pgayvallet pgayvallet requested a review from a team as a code owner July 11, 2024 13:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet pgayvallet added the release_note:skip Skip the PR/issue when compiling release notes label Jul 11, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #42 / Alerting alerts_as_data alerts as data flapping should set flapping and flapping_history for flapping alerts that settle on active
  • [job] [logs] Jest Tests #7 / UserCommentPropertyActions renders the correct number of actions

Metrics [docs]

✅ unchanged

@pgayvallet pgayvallet merged commit 49cfa96 into elastic:main Jul 12, 2024
21 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ssl.redirectHttpFromPort redirects statically to 0.0.0.0:<somePort>
4 participants
@pgayvallet @elasticmachine @afharo @kibanamachine