Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Single Metric Viewer embeddable in dashboards: add tests for anomaly action menu #187801

Merged
merged 6 commits into from
Jul 16, 2024
Merged

[ML] Single Metric Viewer embeddable in dashboards: add tests for anomaly action menu #187801

merged 6 commits into from
Jul 16, 2024

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Jul 8, 2024 •
edited by peteharverson
Loading

Summary

Related meta issue #182235

  • Adds tests for click action on anomaly markers in the single metric viewer embeddable

Checklist

@alvarezmelissa87 alvarezmelissa87 added :ml release_note:skip Skip the PR/issue when compiling release notes Feature:Functional Testing Feature:Embeddables Relating to the Embeddable system v8.16.0 labels Jul 8, 2024
@alvarezmelissa87 alvarezmelissa87 self-assigned this Jul 8, 2024
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner July 8, 2024 21:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson mentioned this pull request Jul 9, 2024
Closed
13 tasks
peteharverson
peteharverson approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes LGTM

@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

@peteharverson peteharverson mentioned this pull request Jul 16, 2024
Closed
23 tasks
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #4 / FilesUtilityBar renders correctly

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.6MB 4.6MB +38.0B

History

cc @alvarezmelissa87

@alvarezmelissa87 alvarezmelissa87 merged commit e49ded9 into elastic:main Jul 16, 2024
21 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 16, 2024
@alvarezmelissa87 alvarezmelissa87 deleted the ml-smv-click-action-test branch July 16, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
backport:skip This commit does not require backporting Feature:Embeddables Relating to the Embeddable system Feature:Functional Testing :ml release_note:skip Skip the PR/issue when compiling release notes v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alvarezmelissa87 @elasticmachine @peteharverson @kibanamachine