Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Unskip search alert serverless tests on MKI #187771

Merged
merged 15 commits into from
Jul 11, 2024
Merged

[Discover] Unskip search alert serverless tests on MKI #187771

merged 15 commits into from
Jul 11, 2024

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Jul 8, 2024 •
edited by kibanamachine
Loading

@jughosta jughosta self-assigned this Jul 8, 2024
@kibanamachine

This comment was marked as outdated.

Sign in to view
@jughosta jughosta changed the title [Discover] Add a retry to search alert flaky tests [Discover] Update search alert flaky tests Jul 8, 2024
@jughosta jughosta changed the title [Discover] Update search alert flaky tests [Discover] Update search alert flaky serverless tests Jul 8, 2024
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6479

[✅] x-pack/test_serverless/functional/test_suites/search/common_configs/config.group6.ts: 25/25 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6489

[✅] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group6.ts: 25/25 tests passed.

see run history

@jughosta jughosta changed the title [Discover] Update search alert flaky serverless tests [Discover] Unskip search alert serverless tests on MKI Jul 9, 2024
@jughosta
Copy link
Contributor Author

jughosta commented Jul 9, 2024

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6490

[✅] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group6.ts: 25/25 tests passed.

see run history

@jughosta jughosta marked this pull request as ready for review July 9, 2024 10:33
@jughosta jughosta requested review from a team as code owners July 9, 2024 10:33
@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jul 9, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@wayneseymour
Copy link
Member

👀

@kertal kertal requested a review from mattkime July 9, 2024 11:03
@wayneseymour
Copy link
Member

wayneseymour commented Jul 9, 2024 •
edited
Loading

I'm running this from my local, right now.
I've created a new oblt project (real serverless [MKI]), using qaf and running the config mentioned here.

But, it's seeing failures. I'll try once again, but this time headless and I'll report back here.

So far, I'm seeing some NoSuchElementError: no such element: Unable to locate element errors, etc.

Have you run this against real MKI, from your local yet? @jughosta

@jughosta
Copy link
Contributor Author

jughosta commented Jul 9, 2024 •
edited
Loading

@wayneseymour I've tested it with qaf for search and security. Worked fine for me.

I will check observability too then.

@wayneseymour
Copy link
Member

@wayneseymour I've tested it with qaf for search and security. Worked fine for me.

I will check observability too then.

Thanks very much @jughosta !

@jughosta
Copy link
Contributor Author

jughosta commented Jul 9, 2024 •
edited
Loading

@wayneseymour Tests are passing for observability project too. Can you please pull the latest changes and run again? At what point in the process do you get the error?

@wayneseymour
Copy link
Member

@jughosta I've added a thread in the #appex-qa channel on slack

@jughosta
Copy link
Contributor Author

Hi @wayneseymour,

Did you have a chance to run tests again?

@wayneseymour
Copy link
Member

Hi @wayneseymour,

Did you have a chance to run tests again?

Let me bring down the lastest changes and re-run! 🤞🏾

@wayneseymour
Copy link
Member

@jughosta Which config should run against mki to verify?

@jughosta
Copy link
Contributor Author

@wayneseymour

x-pack/test_serverless/functional/test_suites/search/common_configs/config.group6.ts --grep="Search source Alert"
x-pack/test_serverless/functional/test_suites/security/common_configs/config.group6.ts --grep="Search source Alert"
x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group6.ts --grep="Search source Alert"

@wayneseymour
Copy link
Member

@jughosta taking it back to slack

lukasolson
lukasolson approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, otherwise LGTM

..._serverless/functional/test_suites/common/discover_ml_uptime/discover/search_source_alert.ts Outdated
await deleteConnector(connectorId);
// clean up what we can in case of failures in some tests which blocked the creation of the following objects
try {
deleteIndexes([OUTPUT_DATA_VIEW, SOURCE_DATA_VIEW]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Is it possible for deleteIndexes to throw? It doesn't look like the function returns the promise or awaits anything. Maybe we can either make the function return a promise and then await it here.

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

cc @jughosta

mattkime
mattkime approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and ran successfully against the MKI environment I spun up. Nice work!

@jughosta jughosta merged commit ee35439 into elastic:main Jul 11, 2024
20 checks passed
@jughosta jughosta deleted the 187069-fix-alert-tests branch July 11, 2024 20:57
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 11, 2024
@jughosta
[Discover] Unskip search alert serverless tests on MKI (elastic#187771)
6e12ffa 
- Closes elastic#187069
- Closes elastic#180101
- Closes elastic#180100

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit ee35439)
@kibanamachine kibanamachine mentioned this pull request Jul 11, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 11, 2024
@kibanamachine @jughosta
[8.15] [Discover] Unskip search alert serverless tests on MKI (#187771)…
7504c38 
… (#188159)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Discover] Unskip search alert serverless tests on MKI
(#187771)](#187771)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-11T20:57:46Z","message":"[Discover]
Unskip search alert serverless tests on MKI (#187771)\n\n- Closes
https://github.com/elastic/kibana/issues/187069\r\n- Closes
https://github.com/elastic/kibana/issues/180101\r\n- Closes
https://github.com/elastic/kibana/issues/180100\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ee3543990b68df1c7c7cf797ae0bda9bdc3af07d","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.16.0"],"title":"[Discover]
Unskip search alert serverless tests on
MKI","number":187771,"url":"https://github.com/elastic/kibana/pull/187771","mergeCommit":{"message":"[Discover]
Unskip search alert serverless tests on MKI (#187771)\n\n- Closes
https://github.com/elastic/kibana/issues/187069\r\n- Closes
https://github.com/elastic/kibana/issues/180101\r\n- Closes
https://github.com/elastic/kibana/issues/180100\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ee3543990b68df1c7c7cf797ae0bda9bdc3af07d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187771","number":187771,"mergeCommit":{"message":"[Discover]
Unskip search alert serverless tests on MKI (#187771)\n\n- Closes
https://github.com/elastic/kibana/issues/187069\r\n- Closes
https://github.com/elastic/kibana/issues/180101\r\n- Closes
https://github.com/elastic/kibana/issues/180100\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ee3543990b68df1c7c7cf797ae0bda9bdc3af07d"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wayneseymour wayneseymour wayneseymour approved these changes

@lukasolson lukasolson lukasolson approved these changes

@mattkime mattkime mattkime approved these changes

Assignees

@jughosta jughosta

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.15.0 v8.16.0
Projects
None yet
Milestone
No milestone
6 participants
@jughosta @kibanamachine @elasticmachine @wayneseymour @mattkime @lukasolson