Fix "Elastic did not load properly" message color when system in dark mode #187653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
added
release_note:skip
jloleysens
approved these changes
Jul 5, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 5, 2024
… mode (elastic#187653) ## Summary fix elastic#187570 The problem was that when the system/browser was in dark mode, the default text color became white, but the background was forced to a specific bright color, so the text became unreadable. A quick fix is to also force the text color (I used EUI text colors) <img width="858" alt="Screenshot 2024-07-05 at 12 44 11" src="https://github.com/elastic/kibana/assets/7784120/9ccefc04-60f6-46e3-a649-4e47cad043ac"> (cherry picked from commit 305f665)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 8, 2024
…en system in dark mode (#187653) (#187670) # Backport This will backport the following commits from `main` to `8.15`: - [Fix "Elastic did not load properly" message color when system in dark mode (#187653)](#187653) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-05T12:30:42Z","message":"Fix \"Elastic did not load properly\" message color when system in dark mode (#187653)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/187570\r\n\r\nThe problem was that when the system/browser was in dark mode, the\r\ndefault text color became white, but the background was forced to a\r\nspecific bright color, so the text became unreadable. A quick fix is to\r\nalso force the text color (I used EUI text colors)\r\n\r\n\r\n<img width=\"858\" alt=\"Screenshot 2024-07-05 at 12 44 11\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7784120/9ccefc04-60f6-46e3-a649-4e47cad043ac\">","sha":"305f66522c2cd4d2c578b33b9f62464de97d7190","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","Feature:Chrome","v8.16.0"],"title":"Fix \"Elastic did not load properly\" message color when system in dark mode","number":187653,"url":"https://github.com/elastic/kibana/pull/187653","mergeCommit":{"message":"Fix \"Elastic did not load properly\" message color when system in dark mode (#187653)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/187570\r\n\r\nThe problem was that when the system/browser was in dark mode, the\r\ndefault text color became white, but the background was forced to a\r\nspecific bright color, so the text became unreadable. A quick fix is to\r\nalso force the text color (I used EUI text colors)\r\n\r\n\r\n<img width=\"858\" alt=\"Screenshot 2024-07-05 at 12 44 11\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7784120/9ccefc04-60f6-46e3-a649-4e47cad043ac\">","sha":"305f66522c2cd4d2c578b33b9f62464de97d7190"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187653","number":187653,"mergeCommit":{"message":"Fix \"Elastic did not load properly\" message color when system in dark mode (#187653)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/187570\r\n\r\nThe problem was that when the system/browser was in dark mode, the\r\ndefault text color became white, but the background was forced to a\r\nspecific bright color, so the text became unreadable. A quick fix is to\r\nalso force the text color (I used EUI text colors)\r\n\r\n\r\n<img width=\"858\" alt=\"Screenshot 2024-07-05 at 12 44 11\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7784120/9ccefc04-60f6-46e3-a649-4e47cad043ac\">","sha":"305f66522c2cd4d2c578b33b9f62464de97d7190"}}]}] BACKPORT--> Co-authored-by: Anton Dosov <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #187570
The problem was that when the system/browser was in dark mode, the default text color became white, but the background was forced to a specific bright color, so the text became unreadable. A quick fix is to also force the text color (I used EUI text colors)