Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Connectors] Remove feature flag for ServiceNow additional fields #186949

Merged
merged 1 commit into from
Jun 26, 2024
Merged

[ResponseOps][Connectors] Remove feature flag for ServiceNow additional fields #186949

merged 1 commit into from
Jun 26, 2024

Conversation

cnasikas
Copy link
Member

Summary

In #184023, we introduced the "additional fields" field for ServiceNow ITSM and SecOps. The field was under a feature flag to follow the intermediate release process. This PR reverts commit 6a593e9 to remove the feature flag.

For maintainers

@cnasikas cnasikas added backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework v8.15.0 labels Jun 26, 2024
@cnasikas cnasikas self-assigned this Jun 26, 2024
@cnasikas cnasikas requested a review from a team as a code owner June 26, 2024 07:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@cnasikas cnasikas added the release_note:skip Skip the PR/issue when compiling release notes label Jun 26, 2024
js-jankisalvi
js-jankisalvi approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #4 / useGetIssueTypes calls the api when invoked with the correct parameters

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackConnectors 554.7KB 554.7KB -32.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

@cnasikas cnasikas merged commit 08dc25b into elastic:main Jun 26, 2024
31 checks passed
@cnasikas cnasikas deleted the sn_additional_fields_remove_ff branch June 26, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js-jankisalvi js-jankisalvi js-jankisalvi approved these changes

Assignees

@cnasikas cnasikas

Labels
backport:skip This commit does not require backporting Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cnasikas @elasticmachine @kibana-ci @js-jankisalvi