-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Set explicit access option for internal API #186882
[Monitoring] Set explicit access option for internal API #186882
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
@tonyghiani I'm questioning the rationale behind flagging this endpoint as Should we "move" this endpoint to the public API? |
Sorry for the late response @consulthys, I marked this endpoint as internal as it was reported in the list of the internal endpoints in the related issue. If this should be a public API, it makes sense to move it then 👌 |
So I guess this is the reason for WARN spam in new Kibana versions?
|
📓 Summary
Part of #186781
Explicit set the
access
options for the monitoring internal API: