-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dataset quality] Tracking kibana:plugin_render_time metric in dataset quality #186627
[Dataset quality] Tracking kibana:plugin_render_time metric in dataset quality #186627
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
</KibanaContextProviderForPlugin> | ||
</SummaryPanelProvider> | ||
</DatasetQualityContext.Provider> | ||
<PerformanceContextProvider> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is PerformanceContextProvider
needed in both here and application.tsx
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, this is what I'm figuring out with Kate.
Dataset quality plugin is not aware that a provider have been placed outside its context
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
History
To update your PR or re-run it, just comment with: cc @yngrdyn |
I modified the current dashboard in staging and now the metrics of Dataset quality are being reported.