Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset quality] Tracking kibana:plugin_render_time metric in dataset quality #186627

Merged
merged 4 commits into from
Jun 29, 2024

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Jun 21, 2024

I modified the current dashboard in staging and now the metrics of Dataset quality are being reported.

image

@yngrdyn yngrdyn requested a review from a team as a code owner June 21, 2024 14:04
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jun 21, 2024
@yngrdyn yngrdyn self-assigned this Jun 21, 2024
@yngrdyn yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label Jun 21, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

</KibanaContextProviderForPlugin>
</SummaryPanelProvider>
</DatasetQualityContext.Provider>
<PerformanceContextProvider>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is PerformanceContextProvider needed in both here and application.tsx?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, this is what I'm figuring out with Kate.
Dataset quality plugin is not aware that a provider have been placed outside its context

@gbamparop gbamparop requested a review from a team June 24, 2024 11:05
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 28, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dataQuality 73 146 +73
datasetQuality 198 271 +73
total +146

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataQuality 25.3KB 111.4KB +86.1KB
datasetQuality 188.7KB 274.5KB +85.8KB
total +171.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataQuality 7.2KB 7.2KB +1.0B
datasetQuality 39.4KB 40.3KB +829.0B
total +830.0B
Unknown metric groups

async chunk count

id before after diff
dataQuality 1 2 +1
datasetQuality 11 12 +1
total +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yngrdyn

@yngrdyn yngrdyn merged commit a6d3169 into elastic:main Jun 29, 2024
29 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants