-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Show multiple agent policies in integrations table #186087
[Fleet] Show multiple agent policies in integrations table #186087
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/fleet (Team:Fleet) |
<EuiListGroup listItems={listItems} color="primary" size="s" /> | ||
</div> | ||
<EuiPopoverFooter> | ||
{/* TODO: implement missing onClick function */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be implemented with #182112
x-pack/plugins/fleet/public/components/multiple_agent_policy_summary_line.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left one suggestion
@juliaElastic I fixed the padding, it should be closer to design now. The |
</EuiPopoverTitle> | ||
<div style={{ width: '280px' }}> | ||
<EuiListGroup | ||
listItems={listItems} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: is this the right component to use? comparing the designs vs the PR screenshots, seems like using this introduces a lot of extra spacing between the elements. how about using simple <ul>
and <li>
s instead?
edit: sorry, just saw Julia comment on the same thing. I feel there is probably still room to tighten up the real estate here though
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @criamico |
👀 |
Closes #182111
Summary
Show multiple agent policies in integrations table.
Testing
enableReusableIntegrationPolicies
NOTE the button "Manage agent policies" does not work for now, as the feature is under development and it's hidden with a feature flag!
With feature flag enabled, when integration has multiple agent policies
When one of the policies is managed:
When feature flag not enabled or integration has only one agent policy
The UI remains as it is today:
Checklist