Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Show multiple agent policies in integrations table #186087

Merged

Conversation

criamico
Copy link
Contributor

@criamico criamico commented Jun 12, 2024

Closes #182111

Summary

Show multiple agent policies in integrations table.

Testing

  • Enable feature flag enableReusableIntegrationPolicies
  • Install an integration that has more than one agent policies associated with it (instructions are here)
  • Navigate to integrations table and verify that the policy displays a badge with the number of associated policies -1 and that it opens up a popover, like in below screenshots.

NOTE the button "Manage agent policies" does not work for now, as the feature is under development and it's hidden with a feature flag!

With feature flag enabled, when integration has multiple agent policies

Screenshot 2024-06-12 at 15 49 34

Screenshot 2024-06-12 at 15 46 38

When one of the policies is managed:
Screenshot 2024-06-13 at 11 30 01

When feature flag not enabled or integration has only one agent policy

The UI remains as it is today:
Screenshot 2024-06-12 at 15 48 56

Checklist

@criamico criamico added the Team:Fleet Team label for Observability Data Collection Fleet team label Jun 12, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@criamico criamico added v8.15.0 release_note:skip Skip the PR/issue when compiling release notes labels Jun 12, 2024
@criamico criamico self-assigned this Jun 12, 2024
@criamico criamico marked this pull request as ready for review June 13, 2024 09:49
@criamico criamico requested a review from a team as a code owner June 13, 2024 09:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@criamico criamico requested a review from juliaElastic June 13, 2024 09:49
<EuiListGroup listItems={listItems} color="primary" size="s" />
</div>
<EuiPopoverFooter>
{/* TODO: implement missing onClick function */}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be implemented with #182112

@juliaElastic
Copy link
Contributor

Looks great! Maybe we could decrease the padding between the list items to be closer to the mockup.
image

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one suggestion

@criamico
Copy link
Contributor Author

@juliaElastic I fixed the padding, it should be closer to design now. The EuiListGroup component is very customisable so there was no need to override the styles :)

Screenshot 2024-06-13 at 14 23 39

</EuiPopoverTitle>
<div style={{ width: '280px' }}>
<EuiListGroup
listItems={listItems}
Copy link
Contributor

@jen-huang jen-huang Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is this the right component to use? comparing the designs vs the PR screenshots, seems like using this introduces a lot of extra spacing between the elements. how about using simple <ul> and <li>s instead?

edit: sorry, just saw Julia comment on the same thing. I feel there is probably still room to tighten up the real estate here though

@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #83 / Fleet Endpoints Integrations inputs_with_standalone_docker_agent "before all" hook for "generate a valid config for standalone agents"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 1031 1032 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.4MB 1.4MB +2.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@criamico criamico merged commit ee15561 into elastic:main Jun 14, 2024
21 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 14, 2024
@criamico criamico deleted the 182111_integrations_UI_multiple_policies branch June 14, 2024 09:36
@nicpenning
Copy link

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show multiple agent policies on integration policies list UI
8 participants