-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Obs AI Assistant] Boost user prompt in recall #184933
[Obs AI Assistant] Boost user prompt in recall #184933
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
WDYT about making |
That's not a bad idea. I'll do that. |
…pt-over-screen-description # Conflicts: # x-pack/plugins/observability_solution/observability_ai_assistant/server/service/client/index.ts
queries: queriesOrUserPrompt, | ||
screenDescription, | ||
userPrompt, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgieselaar Per your comment we now use queries
that includes boost
parameter in recall but for scoring suggestions I am getting better results by telling the LLM what each query is (user prompt and screen description).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually that's a great idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Canvas Sharable Runtime
Page load bundle
History
To update your PR or re-run it, just comment with: |
This reverts commit baa22bb.
In #184933, we removed the parameters for the `context` function, however, OpenAI requires at least an empty `arguments` object, so requests fail. This PR sets arguments to an empty JSON object (`"{}"`) if `function_call.arguments` is empty.
Closes: elastic#180995 --------- Co-authored-by: Dario Gieselaar <[email protected]>
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Closes: elastic#180995 --------- Co-authored-by: Dario Gieselaar <[email protected]> (cherry picked from commit baa22bb) # Conflicts: # x-pack/plugins/observability_solution/observability_ai_assistant/server/service/client/get_context_function_request_if_needed.ts # x-pack/plugins/observability_solution/observability_ai_assistant/server/service/client/index.test.ts # x-pack/plugins/observability_solution/observability_ai_assistant/server/service/client/index.ts # x-pack/plugins/observability_solution/observability_ai_assistant_app/public/components/chat/chat_body.test.tsx
) # Backport This will backport the following commits from `main` to `8.14`: - [[Obs AI Assistant] Boost user prompt in recall (#184933)](#184933) <!--- Backport version: 9.5.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Søren Louv-Jansen","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-06-08T20:32:49Z","message":"[Obs AI Assistant] Boost user prompt in recall (#184933)\n\nCloses: https://github.com/elastic/kibana/issues/180995\r\n\r\n---------\r\n\r\nCo-authored-by: Dario Gieselaar <[email protected]>","sha":"baa22bb16a179f7c5f13caf06afca315f62d0746","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","auto-backport","Team:Obs AI Assistant","ci:project-deploy-observability","v8.15.0","v8.14.2"],"title":"[Obs AI Assistant] Boost user prompt in recall","number":184933,"url":"https://github.com/elastic/kibana/pull/184933","mergeCommit":{"message":"[Obs AI Assistant] Boost user prompt in recall (#184933)\n\nCloses: https://github.com/elastic/kibana/issues/180995\r\n\r\n---------\r\n\r\nCo-authored-by: Dario Gieselaar <[email protected]>","sha":"baa22bb16a179f7c5f13caf06afca315f62d0746"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/184933","number":184933,"mergeCommit":{"message":"[Obs AI Assistant] Boost user prompt in recall (#184933)\n\nCloses: https://github.com/elastic/kibana/issues/180995\r\n\r\n---------\r\n\r\nCo-authored-by: Dario Gieselaar <[email protected]>","sha":"baa22bb16a179f7c5f13caf06afca315f62d0746"}},{"branch":"8.14","label":"v8.14.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
This PR didn't make it on time to be included in the latest BC for v8.14.2. |
In elastic#184933, we removed the parameters for the `context` function, however, OpenAI requires at least an empty `arguments` object, so requests fail. This PR sets arguments to an empty JSON object (`"{}"`) if `function_call.arguments` is empty. (cherry picked from commit 8f3359c)
Closes: elastic#180995 --------- Co-authored-by: Dario Gieselaar <[email protected]> (cherry picked from commit baa22bb)
Closes: #180995