[OAS] Capture and commit serverless bundle #184915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
commented
Jun 6, 2024
Comment on lines
+43
to
+47
| kibana?: { | ||
| settings?: {}; | ||
| cliArgs?: Partial<CliArgs>; | ||
| }; | ||
| adjustTimeout?: (timeout: number) => void; |
There was a problem hiding this comment.
Just enables passing through our special "enable all plugins" setting
| @@ -16,23 +16,29 @@ import { observeLines } from '@kbn/stdio-dev-helpers'; | |||
|
|
|||
| // import type { Result } from './kibana_worker'; | |||
|
|
|||
| interface StartTSWorkerArgs { | |||
| interface StartTSWorkerArgs extends ForkOptions { | |||
There was a problem hiding this comment.
Decided to include all ForkOptions for this util, not strictly needed, but seemed simpler.
|
/ci |
jloleysens
added
Team:Core
|
/ci |
|
Pinging @elastic/kibana-core (Team:Core) |
pgayvallet
approved these changes
Jun 7, 2024
packages/kbn-capture-oas-snapshot-cli/src/run_capture_oas_snapshot_cli.ts
Outdated
Show resolved
Hide resolved
jbudz
approved these changes
Jun 7, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #184719
Adds the ability to capture OAS for
serverlessbuild flavor in addition totraditional. By default the CLI will run for both, but this can be controlled by passing in one of two new flags:--no-serverlessor--no-traditional.See
oas_docs/bundle.serverless.jsonfor output.