Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset quality] Added dataQuality locator #184588

Merged
merged 3 commits into from
May 31, 2024

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented May 31, 2024

Closes #183406

📝 Summary

This PR adds a basic locator to dataQuality plugin, where timeRange filters can be shared

🎥 Demo

Screen.Recording.2024-05-31.at.16.11.18.mov

@yngrdyn yngrdyn requested review from a team as code owners May 31, 2024 13:36
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label May 31, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn self-assigned this May 31, 2024
@yngrdyn yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label May 31, 2024
@kibana-ci
Copy link
Collaborator

kibana-ci commented May 31, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #97 / Dataset quality API tests integrations/integrations.spec.ts basic Integration gets the custom installed integrations returns custom integrations and its datasets map

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dataQuality 67 72 +5

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
dataQuality 5 8 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataQuality 25.4KB 25.3KB -149.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5414 +5414
total size - 8.8MB +8.8MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataQuality 5.7KB 7.2KB +1.5KB
observabilityLogsExplorer 14.2KB 14.3KB +104.0B
total +1.6KB
Unknown metric groups

API count

id before after diff
dataQuality 5 8 +3

ESLint disabled line counts

id before after diff
dataQuality 2 5 +3

Total ESLint disabled count

id before after diff
dataQuality 2 5 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yngrdyn

@yngrdyn yngrdyn merged commit 9a6dacb into elastic:main May 31, 2024
21 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dataset quality] Move page to stack management
6 participants