-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HTTP/OAS] Add descriptions for Logstash pipeline APIs #184266
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some suggestions inline for consideration. Do we have a character limit? The fact that these APIs work only for centrally-managed Logstash pipelines is significant.
Yes, this is the "operation summary" which is used as the title in the navigation bar, so we've added a linting rule to limit its length. Originally we were linting for strings to be less than 30, though I've updated that now to go as much as 45. If all of these APIs apply to the same type of pipeline, it would be my preference to cover that either at the group level (in a "tag" description) or in the API detailed description and leave these nav titles as short as they are in the existing docs. It's also worth calling out that our guidelines for these summaries is that they "use common verbs like Get, Update, Delete whenever possible" so the suggested changes to "Retrieve" and "List" would fail a linting rule too. |
Thanks for explaining the constraints. I modified my comments to use standard terminology and to respect the character limit... assuming that only display text counts against character limits. :-) Please LMKWYT |
Co-authored-by: Karen Metts <[email protected]>
Co-authored-by: Karen Metts <[email protected]>
Co-authored-by: Karen Metts <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (pending passing ci). :-) Thanks for your work on this, @lcawl
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
To update your PR or re-run it, just comment with: |
Summary
Relates to #180056
This PR adds operation summaries for the Logstash configuration management APIs in the generated OpenAPI document.
NOTE: I've omitted the "access: public" from the "delete pipelines" and "get all pipelines" operations, since those don't currently exist in the documentation. I believe this means they'll use the default "internal" access value.
How to test
Per #181277:
yarn es snapshot --license trial
)server.oas.enabled: true
tokibana.dev.yml
yarn start --no-base-path
)The output will contain info like this: