[Share Modal ]fix flaky test #183679
Merged
[Share Modal ]fix flaky test #183679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
rshen91
added
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
eokoneyo
reviewed
May 21, 2024
|
|
||
| const url = await PageObjects.reporting.getReportURL(60000); | ||
| const res = await PageObjects.reporting.getResponse(url ?? ''); | ||
| if (await PageObjects.share.isShareMenuOpen()) { | ||
| await PageObjects.share.closeShareModal(); |
There was a problem hiding this comment.
Wrapping closeShareModal actually doesn't make a substantial difference, since it's definition already performs this a conditional check, see https://github.com/elastic/kibana/blob/main/test/functional/page_objects/share_page.ts#L20-L26
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @rshen91 |
kibanamachine
added
v8.15.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #183566