Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Obs AI Assistant] Add scoped privileges to readUser and writeUser #183592

Merged
merged 8 commits into from
May 22, 2024
Merged

[Obs AI Assistant] Add scoped privileges to readUser and writeUser #183592

merged 8 commits into from
May 22, 2024

Conversation

sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented May 16, 2024 •
edited
Loading

Closes #183588

  • Rename readUser to viewerUser
  • Rename writeUser to editorUser
  • Replace testUser with editorUser in functional tests

@sorenlouv sorenlouv requested a review from a team as a code owner May 16, 2024 07:24
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant labels May 16, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@sorenlouv sorenlouv added v8.15.0 release_note:skip Skip the PR/issue when compiling release notes labels May 16, 2024
miltonhultgren
miltonhultgren approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@miltonhultgren miltonhultgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, thanks!

x-pack/test/observability_ai_assistant_api_integration/common/config.ts Outdated Show resolved Hide resolved
x-pack/test/observability_ai_assistant_api_integration/common/users/users.ts Show resolved Hide resolved
x-pack/test/observability_ai_assistant_api_integration/common/config.ts Outdated Show resolved Hide resolved
x-pack/test/observability_ai_assistant_api_integration/common/users/users.ts Outdated Show resolved Hide resolved
@sorenlouv sorenlouv enabled auto-merge (squash) May 21, 2024 11:04
@kibana-ci
Copy link
Collaborator

kibana-ci commented May 22, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5412 +5412
total size - 8.8MB +8.8MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit 97de948 into elastic:main May 22, 2024
22 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 22, 2024
@sorenlouv sorenlouv deleted the create-roles-users-in-api-tests branch May 22, 2024 07:13
@sorenlouv sorenlouv mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miltonhultgren miltonhultgren miltonhultgren approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Obs AI Assistant] Add ability to call APIs with non-superuser in API tests
5 participants
@sorenlouv @apmmachine @kibana-ci @miltonhultgren @kibanamachine