Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix issues related to publish #183393

Merged
merged 2 commits into from
May 15, 2024
Merged

[CI] Fix issues related to publish #183393

merged 2 commits into from
May 15, 2024

Conversation

delanni
Copy link
Contributor

@delanni delanni commented May 14, 2024 •
edited
Loading

Summary

On the new infra, the publish step will still require legacy vault credentials and login. (https://buildkite.com/elastic/kibana-artifacts-staging/builds/3513#018f7691-73c8-4e6f-862b-328b05d9de3b)

As a fix: this PR digs up the credentials from the vault instead of gcloud secrets on the new infra.

Also, other usages of role-id/secret-id is used are moved in the legacy-vault usages, plus minor code re-org, to reduce branching, and future cleanup.

Fix after: #182582

@delanni delanni added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:cloud-deploy Create or update a Cloud deployment ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project labels May 14, 2024
@delanni delanni marked this pull request as ready for review May 14, 2024 15:08
@delanni delanni requested a review from a team as a code owner May 14, 2024 15:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@delanni
Copy link
Contributor Author

delanni commented May 14, 2024

Also: https://buildkite.com/elastic/kibana-artifacts-staging/builds/3517#018f7711-5364-43b2-9f79-d6927dfc0d22 this is a 8.14 run that logs that the credentials were retrieved successfully.

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 14, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5407 +5407
total size - 8.8MB +8.8MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@delanni delanni merged commit 05fce3b into elastic:main May 15, 2024
24 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 15, 2024
@delanni
[CI] Fix issues related to publish (elastic#183393)
7ce156c 
## Summary
On the new infra, the publish step will still require legacy vault
credentials and login.
(https://buildkite.com/elastic/kibana-artifacts-staging/builds/3513#018f7691-73c8-4e6f-862b-328b05d9de3b)

As a fix: this PR digs up the credentials from the vault instead of
gcloud secrets on the new infra.

Also, other usages of role-id/secret-id is used are moved in the
legacy-vault usages, plus minor code re-org, to reduce branching, and
future cleanup.

(cherry picked from commit 05fce3b)
@kibanamachine kibanamachine mentioned this pull request May 15, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 15, 2024
@kibanamachine @delanni
[8.14] [CI] Fix issues related to publish (#183393) (#183467)
86e5e16 
# Backport

This will backport the following commits from `main` to `8.14`:
- [[CI] Fix issues related to publish
(#183393)](#183393)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alex
Szabo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-05-15T07:42:42Z","message":"[CI]
Fix issues related to publish (#183393)\n\n## Summary\r\nOn the new
infra, the publish step will still require legacy vault\r\ncredentials
and
login.\r\n(https://buildkite.com/elastic/kibana-artifacts-staging/builds/3513#018f7691-73c8-4e6f-862b-328b05d9de3b)\r\n\r\nAs
a fix: this PR digs up the credentials from the vault instead
of\r\ngcloud secrets on the new infra.\r\n\r\nAlso, other usages of
role-id/secret-id is used are moved in the\r\nlegacy-vault usages, plus
minor code re-org, to reduce branching, and\r\nfuture
cleanup.","sha":"05fce3b4badb0ed5abc7cfab0e529dd8a39e2827","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:prev-minor","ci:cloud-deploy","ci:project-deploy-elasticsearch","v8.15.0"],"title":"[CI]
Fix issues related to
publish","number":183393,"url":"https://github.com/elastic/kibana/pull/183393","mergeCommit":{"message":"[CI]
Fix issues related to publish (#183393)\n\n## Summary\r\nOn the new
infra, the publish step will still require legacy vault\r\ncredentials
and
login.\r\n(https://buildkite.com/elastic/kibana-artifacts-staging/builds/3513#018f7691-73c8-4e6f-862b-328b05d9de3b)\r\n\r\nAs
a fix: this PR digs up the credentials from the vault instead
of\r\ngcloud secrets on the new infra.\r\n\r\nAlso, other usages of
role-id/secret-id is used are moved in the\r\nlegacy-vault usages, plus
minor code re-org, to reduce branching, and\r\nfuture
cleanup.","sha":"05fce3b4badb0ed5abc7cfab0e529dd8a39e2827"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/183393","number":183393,"mergeCommit":{"message":"[CI]
Fix issues related to publish (#183393)\n\n## Summary\r\nOn the new
infra, the publish step will still require legacy vault\r\ncredentials
and
login.\r\n(https://buildkite.com/elastic/kibana-artifacts-staging/builds/3513#018f7691-73c8-4e6f-862b-328b05d9de3b)\r\n\r\nAs
a fix: this PR digs up the credentials from the vault instead
of\r\ngcloud secrets on the new infra.\r\n\r\nAlso, other usages of
role-id/secret-id is used are moved in the\r\nlegacy-vault usages, plus
minor code re-org, to reduce branching, and\r\nfuture
cleanup.","sha":"05fce3b4badb0ed5abc7cfab0e529dd8a39e2827"}}]}]
BACKPORT-->

Co-authored-by: Alex Szabo <[email protected]>
@delanni delanni added backport:all-open Backport to all branches that could still receive a release and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels May 15, 2024
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts
❌ 8.14 Cherrypick failed because the selected commit (05fce3b) is empty. It looks like the commit was already backported in #183467

Manual backport

To create the backport manually run:

node scripts/backport --pr 183393

Questions ?

Please refer to the Backport tool documentation

delanni added a commit to delanni/kibana that referenced this pull request May 15, 2024
@delanni
[CI] Fix issues related to publish (elastic#183393)
c2798e7 
## Summary
On the new infra, the publish step will still require legacy vault
credentials and login.
(https://buildkite.com/elastic/kibana-artifacts-staging/builds/3513#018f7691-73c8-4e6f-862b-328b05d9de3b)

As a fix: this PR digs up the credentials from the vault instead of
gcloud secrets on the new infra.

Also, other usages of role-id/secret-id is used are moved in the
legacy-vault usages, plus minor code re-org, to reduce branching, and
future cleanup.

(cherry picked from commit 05fce3b)

# Conflicts:
#	.buildkite/scripts/steps/cloud/build_and_deploy.sh
#	.buildkite/scripts/steps/serverless/deploy.sh
@delanni delanni mentioned this pull request May 15, 2024
Merged
@delanni
Copy link
Contributor Author

delanni commented May 15, 2024

💚 All backports created successfully

Status Branch Result
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

delanni added a commit that referenced this pull request May 15, 2024
@delanni
[7.17] [CI] Fix issues related to publish (#183393) (#183547)
a138c41 
# Backport

This will backport the following commits from `main` to `7.17`:
- [[CI] Fix issues related to publish
(#183393)](#183393)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
delanni added a commit to delanni/kibana that referenced this pull request May 16, 2024
@delanni
[CI] Fix issues related to publish (elastic#183393)
81910b2 
## Summary
On the new infra, the publish step will still require legacy vault
credentials and login.
(https://buildkite.com/elastic/kibana-artifacts-staging/builds/3513#018f7691-73c8-4e6f-862b-328b05d9de3b)

As a fix: this PR digs up the credentials from the vault instead of
gcloud secrets on the new infra.

Also, other usages of role-id/secret-id is used are moved in the
legacy-vault usages, plus minor code re-org, to reduce branching, and
future cleanup.

(cherry picked from commit 05fce3b)

# Conflicts:
#	.buildkite/scripts/steps/serverless/build_and_deploy.sh
@delanni delanni mentioned this pull request May 16, 2024
Merged
@delanni
Copy link
Contributor Author

delanni commented May 16, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

delanni added a commit that referenced this pull request May 16, 2024
@delanni
[8.13] [CI] Fix issues related to publish (#183393) (#183602)
ace1bbf 
# Backport

This will backport the following commits from `main` to `8.13`:
- [[CI] Fix issues related to publish
(#183393)](#183393)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
@szaffarano szaffarano mentioned this pull request Jul 12, 2024
Closed
adelisle pushed a commit to Makila-AI/kibana that referenced this pull request Aug 5, 2024
@delanni @adelisle
[7.17] [CI] Fix issues related to publish (elastic#183393) (elastic#1…
01a308c 
…83547)

# Backport

This will backport the following commits from `main` to `7.17`:
- [[CI] Fix issues related to publish
(elastic#183393)](elastic#183393)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ikuni17 Ikuni17 Ikuni17 approved these changes

Assignees
No one assigned
Labels
backport:all-open Backport to all branches that could still receive a release ci:cloud-deploy Create or update a Cloud deployment ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.13.5 v8.14.0 v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@delanni @elasticmachine @kibana-ci @kibanamachine @Ikuni17